Re: [PATCH, fortran/52879] RANDOM_SEED revisited

2014-02-10 Thread Steve Kargl
On Mon, Feb 10, 2014 at 05:23:39PM +0200, Janne Blomqvist wrote: > On Sun, Feb 9, 2014 at 2:40 AM, Steve Kargl > wrote: > > All, > > > > Here is a potentially contentious patch for PR fortran/52879. > > > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52879 > > > > As demonstrated in that PR, it is

Re: [PATCH, fortran/52879] RANDOM_SEED revisited

2014-02-10 Thread Janne Blomqvist
On Sun, Feb 9, 2014 at 2:40 AM, Steve Kargl wrote: > All, > > Here is a potentially contentious patch for PR fortran/52879. > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52879 > > As demonstrated in that PR, it is possible to provide RANDOM_SEED > with sets of seeds that result in a very poor se

Re: [PATCH, fortran/52879] RANDOM_SEED revisited

2014-02-09 Thread Steve Kargl
On Sun, Feb 09, 2014 at 03:31:09PM +0100, Dominique Dhumieres wrote: > Steve, > > First, it is needed to remove the line > > mpz_t put_size, get_size; > > in gcc/fortran/check.c, otherwise compiling the file with -Werror > (default) fails. OK. > Second, the patch breaks the interface of RAND

Re: [PATCH, fortran/52879] RANDOM_SEED revisited

2014-02-09 Thread Dominique Dhumieres
Steve, First, it is needed to remove the line mpz_t put_size, get_size; in gcc/fortran/check.c, otherwise compiling the file with -Werror (default) fails. Second, the patch breaks the interface of RANDOM_SEED(GET/PUT...) as shown for gfortran.dg/random_seed_1.f90 and the original test in pr52

[PATCH, fortran/52879] RANDOM_SEED revisited

2014-02-08 Thread Steve Kargl
All, Here is a potentially contentious patch for PR fortran/52879. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52879 As demonstrated in that PR, it is possible to provide RANDOM_SEED with sets of seeds that result in a very poor sequences of PRN. Gfortran's RANDOM_NUMBER uses 3 independent KISS