Re: [PATCH, i386]: Improve STV conversion of shifts

2019-08-30 Thread Richard Biener
On Thu, Aug 29, 2019 at 9:54 AM Uros Bizjak wrote: > > On Wed, Aug 28, 2019 at 5:12 PM Uros Bizjak wrote: > > > > Attached patch improves costing for STV shifts and corrects reject > > condition for out of range shift count operands. > > > > 2019-08-28 Uroš Bizjak > > > > * config/i386/i38

Re: [PATCH, i386]: Fix secondary_reload_needed (was: Re: [PATCH, i386]: Improve STV conversion of shifts)

2019-08-29 Thread Uros Bizjak
And the patch... On Thu, Aug 29, 2019 at 12:00 PM Uros Bizjak wrote: > > As usual with costing changes, the patch exposes latent problem. The > patched compiler tries to generate non-existing DImode move from mask > register to XMM register, and ICEs during reload [1]. Attached patch > tightens s

[PATCH, i386]: Fix secondary_reload_needed (was: Re: [PATCH, i386]: Improve STV conversion of shifts)

2019-08-29 Thread Uros Bizjak
As usual with costing changes, the patch exposes latent problem. The patched compiler tries to generate non-existing DImode move from mask register to XMM register, and ICEs during reload [1]. Attached patch tightens secondary_reload_needed condition and fixes the issue. I'm bootstrapping and regr

Re: [PATCH, i386]: Improve STV conversion of shifts

2019-08-29 Thread Uros Bizjak
On Wed, Aug 28, 2019 at 5:12 PM Uros Bizjak wrote: > > Attached patch improves costing for STV shifts and corrects reject > condition for out of range shift count operands. > > 2019-08-28 Uroš Bizjak > > * config/i386/i386-features.c > (general_scalar_chain::compute_convert_gain): >

[PATCH, i386]: Improve STV conversion of shifts

2019-08-28 Thread Uros Bizjak
Attached patch improves costing for STV shifts and corrects reject condition for out of range shift count operands. 2019-08-28 Uroš Bizjak * config/i386/i386-features.c (general_scalar_chain::compute_convert_gain): Correct cost for double-word shifts. (general_scalar_to_vector_