Re: [PATCH, libcpp] Do not decrease highest_location if the included file has be included twice.

2013-06-24 Thread Tom Tromey
> "Dehao" == Dehao Chen writes: Dehao> Thanks for helping update the patch. The new patch passed all Dehao> regression test and can fix the problem in my huge source file. I Dehao> added ChangeLog entry to the patch. Could any libcpp maintainers help Dehao> check if it is ok for trunk? I'm s

Re: [PATCH, libcpp] Do not decrease highest_location if the included file has be included twice.

2013-06-21 Thread Dehao Chen
ping ^3 Thx, Dehao On Sat, Jun 15, 2013 at 9:48 AM, Dehao Chen wrote: > ping ^2 > > > On Thu, Jun 6, 2013 at 9:22 PM, Dehao Chen wrote: >> >> ping... >> >> On Tue, Jun 4, 2013 at 10:02 AM, Dehao Chen wrote: >> > Hi, Dodji, >> > >> > Thanks for helping update the patch. The new patch passed all

Re: [PATCH, libcpp] Do not decrease highest_location if the included file has be included twice.

2013-06-15 Thread Dehao Chen
ping ^2 On Tue, Jun 4, 2013 at 10:02 AM, Dehao Chen wrote: > Hi, Dodji, > > Thanks for helping update the patch. The new patch passed all > regression test and can fix the problem in my huge source file. I > added ChangeLog entry to the patch. Could any libcpp maintainers help > check if it is ok

Re: [PATCH, libcpp] Do not decrease highest_location if the included file has be included twice.

2013-06-06 Thread Dehao Chen
ping... On Tue, Jun 4, 2013 at 10:02 AM, Dehao Chen wrote: > Hi, Dodji, > > Thanks for helping update the patch. The new patch passed all > regression test and can fix the problem in my huge source file. I > added ChangeLog entry to the patch. Could any libcpp maintainers help > check if it is ok

Re: [PATCH, libcpp] Do not decrease highest_location if the included file has be included twice.

2013-06-04 Thread Dehao Chen
Hi, Dodji, Thanks for helping update the patch. The new patch passed all regression test and can fix the problem in my huge source file. I added ChangeLog entry to the patch. Could any libcpp maintainers help check if it is ok for trunk? Thanks, Dehao libcpp/ChangeLog: 2013-06-04 Dehao Chen

Re: [PATCH, libcpp] Do not decrease highest_location if the included file has be included twice.

2013-06-04 Thread Dodji Seketeli
Dehao Chen a écrit: >> So, I'd say that in this hunk of your patch: >> >>> @@ -1002,7 +1002,8 @@ _cpp_stack_include (cpp_reader *pfile, const char >>> linemap_add is not called) or we were included from the >>> command-line. */ >>>if (file->pchname == NULL && file->err_no == 0 >>

Re: [PATCH, libcpp] Do not decrease highest_location if the included file has be included twice.

2013-06-03 Thread Dehao Chen
On Mon, Jun 3, 2013 at 11:46 AM, Dodji Seketeli wrote: > Dehao Chen a écrit: > >> Thanks for looking into this. > > You are welcome. Libcpp is fun. Is it not? :-) It truly is ;-) > >> The reason a test is missing is that it would need a super large >> source file to reproduce the problem. >

Re: [PATCH, libcpp] Do not decrease highest_location if the included file has be included twice.

2013-06-03 Thread Dodji Seketeli
Dehao Chen a écrit: > Thanks for looking into this. You are welcome. Libcpp is fun. Is it not? :-) > The reason a test is missing is that it would need a super large > source file to reproduce the problem. I see. It's kind of a pity that we cannot have tests for interesting cases like this

Re: [PATCH, libcpp] Do not decrease highest_location if the included file has be included twice.

2013-06-03 Thread Dehao Chen
Hi, Dodji, Thanks for looking into this. The reason a test is missing is that it would need a super large source file to reproduce the problem. However, if you apply the attached patch, you can reproduce the problem with attached testcase: g++ a.cpp -g -S -c -o a.s in a.s, the linenos are off-b

Re: [PATCH, libcpp] Do not decrease highest_location if the included file has be included twice.

2013-06-03 Thread Dodji Seketeli
Hello Dehao, Dehao Chen a écrit: > This patch fixes the bug that when include a header file, if the > header file is already included (with #define _HEADER_H_), libcpp > should not decrease its highest_location, otherwise it'll cause > incorrect source location when source location numbers are l

[PATCH, libcpp] Do not decrease highest_location if the included file has be included twice.

2013-06-01 Thread Dehao Chen
This patch fixes the bug that when include a header file, if the header file is already included (with #define _HEADER_H_), libcpp should not decrease its highest_location, otherwise it'll cause incorrect source location when source location numbers are large enough to omit columns. Passed regress