[PATCH, libffi, alpha]: Use FFI_ASSERT in ffi_closure_osf_inner

2014-07-21 Thread Uros Bizjak
Hello! Attached patch fixes libgo reflect test failure with libffi closures. The gccgo compiler started to use FFI closures recently; the compiler passes ffi_type_void for structures with zero members. ffi_call form src/alpha/ffi.c allows FFI_TYPE_VOID arguments in non-debug mode through the defa

Re: [PATCH, libffi, alpha]: Use FFI_ASSERT in ffi_closure_osf_inner

2014-07-25 Thread Uros Bizjak
On Mon, Jul 21, 2014 at 8:21 PM, Uros Bizjak wrote: > Attached patch fixes libgo reflect test failure with libffi closures. > The gccgo compiler started to use FFI closures recently; the compiler > passes ffi_type_void for structures with zero members. > > ffi_call form src/alpha/ffi.c allows FFI

Re: [PATCH, libffi, alpha]: Use FFI_ASSERT in ffi_closure_osf_inner

2014-09-20 Thread Anthony Green
[replying to an ancient post here..] Uros Bizjak writes: > Hello! > > Attached patch fixes libgo reflect test failure with libffi closures. > The gccgo compiler started to use FFI closures recently; the compiler > passes ffi_type_void for structures with zero members. Why not just pass an FFI_

Re: [PATCH, libffi, alpha]: Use FFI_ASSERT in ffi_closure_osf_inner

2014-09-20 Thread Jay
On Sep 20, 2014, at 3:04 AM, Anthony Green wrote: > > Why not just pass an FFI_TYPE_STRUCT with zero members? My information may be old or irrelevant but I have used structs with no members with gcc backend, but with nonzero size and alignment, and ran into backend problems, particularly on

Re: [PATCH, libffi, alpha]: Use FFI_ASSERT in ffi_closure_osf_inner

2014-09-20 Thread Ian Lance Taylor
On Sat, Sep 20, 2014 at 3:04 AM, Anthony Green wrote: > >> Attached patch fixes libgo reflect test failure with libffi closures. >> The gccgo compiler started to use FFI closures recently; the compiler >> passes ffi_type_void for structures with zero members. > > Why not just pass an FFI_TYPE_STRU

Re: [PATCH, libffi, alpha]: Use FFI_ASSERT in ffi_closure_osf_inner

2014-09-21 Thread Uros Bizjak
On Sat, Sep 20, 2014 at 12:04 PM, Anthony Green wrote: > > [replying to an ancient post here..] > > Uros Bizjak writes: > >> Hello! >> >> Attached patch fixes libgo reflect test failure with libffi closures. >> The gccgo compiler started to use FFI closures recently; the compiler >> passes ffi_ty