Hi, The parameter names here were in the wrong order (which doesn't matter to the interpreter, but confuses the humans reading the calling code).
I am going to install the following patch soon.
gcc/ChangeLog: * gdbhooks.py (GdbPrettyPrinters.add_printer_for_types): Reorder parameter names in accord with usage (no functional change). (GdbPrettyPrinters.add_printer_for_regex): Ditto. --- gcc/gdbhooks.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/gdbhooks.py b/gcc/gdbhooks.py index 7b1a7be0002..15a5ceaa56f 100644 --- a/gcc/gdbhooks.py +++ b/gcc/gdbhooks.py @@ -521,11 +521,11 @@ class GdbPrettyPrinters(gdb.printing.PrettyPrinter): def __init__(self, name): super(GdbPrettyPrinters, self).__init__(name, []) - def add_printer_for_types(self, name, class_, types): - self.subprinters.append(GdbSubprinterTypeList(name, class_, types)) + def add_printer_for_types(self, types, name, class_): + self.subprinters.append(GdbSubprinterTypeList(types, name, class_)) - def add_printer_for_regex(self, name, class_, regex): - self.subprinters.append(GdbSubprinterRegex(name, class_, regex)) + def add_printer_for_regex(self, regex, name, class_): + self.subprinters.append(GdbSubprinterRegex(regex, name, class_)) def __call__(self, gdbval): type_ = gdbval.type.unqualified() -- 2.22.0
-- Vlad