[PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

Hi, This patch is for internal issue1136. It changes insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions. These instructions all use DI registers and can be invoked with -mpowerpc64 in a 32-bit environment. This patch also changes prototypes of rela

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

Hi Haochen, on 2022/8/19 10:35, HAO CHEN GUI wrote: > Hi, > > This patch is for internal issue1136. It changes insn condition from > TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions. > These instructions all use DI registers and can be invoked with -mpowerpc64 > in a

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

Hi Kewen, On 19/8/2022 上午 11:01, Kewen.Lin wrote: > Maybe we should add one comment here (also the other touched case) or > in the commit log saying why we reorder the dg-require-effective-target > and dg-options, since the reason isn't obvious. :) Sure, I will explain it in commit log. I submit

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

Hi! On Fri, Aug 19, 2022 at 10:35:54AM +0800, HAO CHEN GUI wrote: > --- a/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-0.c > +++ b/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-0.c > @@ -1,7 +1,8 @@ > /* { dg-do compile { target { powerpc*-*-* } } } */ > -/* { dg-require-effe

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

Hi Segher, On 23/8/2022 下午 10:26, Segher Boessenkool wrote: > Hi! > > On Fri, Aug 19, 2022 at 10:35:54AM +0800, HAO CHEN GUI wrote: >> --- a/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-0.c >> +++ b/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-0.c >> @@ -1,7 +1,8 @@ >> /* {

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

on 2022/8/24 13:11, HAO CHEN GUI wrote: > Hi Segher, > > On 23/8/2022 下午 10:26, Segher Boessenkool wrote: >> Hi! >> >> On Fri, Aug 19, 2022 at 10:35:54AM +0800, HAO CHEN GUI wrote: >>> --- a/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-0.c >>> +++ b/gcc/testsuite/gcc.target/powerpc/bfp/

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

Hi Kewen, On 24/8/2022 下午 1:24, Kewen.Lin wrote: > Could you try to test with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" all > the time, but still > having that has_arch_ppc64 effective target on aix? > > I'd expect has_arch_ppc64 check to fail on aix 32bit, the error will not be a > problem

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

Hi, On 24/8/2022 下午 1:24, Kewen.Lin wrote: > Could you try to test with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" all > the time, but still > having that has_arch_ppc64 effective target on aix? > > I'd expect has_arch_ppc64 check to fail on aix 32bit, the error will not be a > problem (turn

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

on 2022/8/25 11:37, HAO CHEN GUI wrote: > Hi, > > On 24/8/2022 下午 1:24, Kewen.Lin wrote: >> Could you try to test with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" all >> the time, but still >> having that has_arch_ppc64 effective target on aix? >> >> I'd expect has_arch_ppc64 check to fail on a

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

On Thu, Aug 25, 2022 at 1:22 AM Kewen.Lin wrote: > > on 2022/8/25 11:37, HAO CHEN GUI wrote: > > Hi, > > > > On 24/8/2022 下午 1:24, Kewen.Lin wrote: > >> Could you try to test with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" > >> all the time, but still > >> having that has_arch_ppc64 effective

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

On Wed, Aug 24, 2022 at 01:11:39PM +0800, HAO CHEN GUI wrote: > On 23/8/2022 下午 10:26, Segher Boessenkool wrote: > > On Fri, Aug 19, 2022 at 10:35:54AM +0800, HAO CHEN GUI wrote: > >> --- a/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-0.c > >> +++ b/gcc/testsuite/gcc.target/powerpc/bfp/s

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

Hi David, On 25/8/2022 下午 10:01, David Edelsohn wrote: > On Thu, Aug 25, 2022 at 1:22 AM Kewen.Lin wrote: >> >> on 2022/8/25 11:37, HAO CHEN GUI wrote: >>> Hi, >>> >>> On 24/8/2022 下午 1:24, Kewen.Lin wrote: Could you try to test with dg-options "-mdejagnu-cpu=power9 -mpowerpc64" all th

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

on 2022/8/26 10:42, HAO CHEN GUI wrote: > Hi David, > > On 25/8/2022 下午 10:01, David Edelsohn wrote: >> On Thu, Aug 25, 2022 at 1:22 AM Kewen.Lin wrote: >>> >>> on 2022/8/25 11:37, HAO CHEN GUI wrote: Hi, On 24/8/2022 下午 1:24, Kewen.Lin wrote: > Could you try to test with dg-op

Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

On Thu, Aug 25, 2022 at 10:42 PM HAO CHEN GUI wrote: > > Hi David, > > On 25/8/2022 下午 10:01, David Edelsohn wrote: > > On Thu, Aug 25, 2022 at 1:22 AM Kewen.Lin wrote: > >> > >> on 2022/8/25 11:37, HAO CHEN GUI wrote: > >>> Hi, > >>> > >>> On 24/8/2022 下午 1:24, Kewen.Lin wrote: > Could you