Re: [PATCH, rs6000] Fix PR85755: PowerPC Gcc's -mupdate produces inefficient code

On 6/8/18 12:12 PM, Segher Boessenkool wrote: > On Fri, Jun 08, 2018 at 12:07:34PM -0500, Peter Bergner wrote: >> On 6/8/18 11:21 AM, Segher Boessenkool wrote: >>> On Fri, Jun 08, 2018 at 10:35:22AM -0500, Peter Bergner wrote: +/* { dg-final { scan-assembler-times {\mstdu\M} 2 } } */ +/*

Re: [PATCH, rs6000] Fix PR85755: PowerPC Gcc's -mupdate produces inefficient code

On Fri, Jun 08, 2018 at 12:07:34PM -0500, Peter Bergner wrote: > On 6/8/18 11:21 AM, Segher Boessenkool wrote: > > On Fri, Jun 08, 2018 at 10:35:22AM -0500, Peter Bergner wrote: > >> +/* { dg-final { scan-assembler-times {\mstdu\M} 2 } } */ > >> +/* { dg-final { scan-assembler-not {\mstfdu\M} } } *

Re: [PATCH, rs6000] Fix PR85755: PowerPC Gcc's -mupdate produces inefficient code

On 6/8/18 11:21 AM, Segher Boessenkool wrote: > On Fri, Jun 08, 2018 at 10:35:22AM -0500, Peter Bergner wrote: >> +/* { dg-final { scan-assembler-times {\mstdu\M} 2 } } */ >> +/* { dg-final { scan-assembler-not {\mstfdu\M} } } */ > > Does this need p8 at all? Would it be better to just test witho

Re: [PATCH, rs6000] Fix PR85755: PowerPC Gcc's -mupdate produces inefficient code

On Fri, Jun 08, 2018 at 10:35:22AM -0500, Peter Bergner wrote: > The fix for PR83969 accidentally disallowed PRE_INC and PRE_DEC addresses > from being matched for the Y constraint leading to poor code generation. > The old PRE_INC and PRE_DEC addresses were originally accepted via the > address_of

Re: [PATCH, rs6000] Fix PR85755: PowerPC Gcc's -mupdate produces inefficient code

On 6/7/18 8:16 PM, Peter Bergner wrote: > On 6/7/18 5:12 PM, Peter Bergner wrote: >> Is this ok for trunk and the release branches where the earlier fixes >> were backported to, assuming no bootstrap errors and the testsuite runs >> do not show any regressions? > > Hold off for now. I'm seeing a

Re: [PATCH, rs6000] Fix PR85755: PowerPC Gcc's -mupdate produces inefficient code

On 6/7/18 5:12 PM, Peter Bergner wrote: > Is this ok for trunk and the release branches where the earlier fixes > were backported to, assuming no bootstrap errors and the testsuite runs > do not show any regressions? Hold off for now. I'm seeing a TImode issue I need to debug first. Peter

[PATCH, rs6000] Fix PR85755: PowerPC Gcc's -mupdate produces inefficient code

The fix for PR83969 accidentally disallowed PRE_INC and PRE_DEC addresses from being matched for the Y constraint leading to poor code generation. The following patch resurrects the fix for PR84279 (early test for altivec addresses) and then moves the call to rs6000_offsettable_memref_p below the a