Re: [PATCH, rs6000] Implemented f[min/max]_optab by xs[min/max]dp [PR103605]

Hi~ On Wed, May 11, 2022 at 04:53:08PM +0800, Kewen.Lin wrote: > on 2022/5/10 20:27, Segher Boessenkool wrote: > > Yes. RTL iterators and attributes are textual replacement and expansion > > only: there is no deeper semantic meaning to it. In fact, we should > > have only a "minmax" iterator and

Re: [PATCH, rs6000] Implemented f[min/max]_optab by xs[min/max]dp [PR103605]

Hi Segher, on 2022/5/10 20:27, Segher Boessenkool wrote: > Hi guys, > > On Mon, May 09, 2022 at 12:05:51PM +0800, Kewen.Lin wrote: >> on 2022/5/9 09:54, HAO CHEN GUI wrote: >>> This patch implements optab f[min/max]_optab by xs[min/max]dp on rs6000. >>> Tests show that outputs of xs[min/max]dp

Re: [PATCH, rs6000] Implemented f[min/max]_optab by xs[min/max]dp [PR103605]

On Tue, May 10, 2022 at 02:56:58PM -0400, Michael Meissner wrote: > On Tue, May 10, 2022 at 07:27:30AM -0500, Segher Boessenkool wrote: > > > IMHO, it's something we want to fix as well, based on the reasons: > > > 1) bif names have the corresponding mnemonics, users would expect 1-1 > > > mappi

Re: [PATCH, rs6000] Implemented f[min/max]_optab by xs[min/max]dp [PR103605]

On Tue, May 10, 2022 at 07:27:30AM -0500, Segher Boessenkool wrote: > > IMHO, it's something we want to fix as well, based on the reasons: > > 1) bif names have the corresponding mnemonics, users would expect 1-1 > > mapping here. > > 2) clang emits xs{min,max}dp all the time, with cpu type po

Re: [PATCH, rs6000] Implemented f[min/max]_optab by xs[min/max]dp [PR103605]

Hi guys, On Mon, May 09, 2022 at 12:05:51PM +0800, Kewen.Lin wrote: > on 2022/5/9 09:54, HAO CHEN GUI wrote: > > This patch implements optab f[min/max]_optab by xs[min/max]dp on rs6000. > > Tests show that outputs of xs[min/max]dp are consistent with the standard > > of C99 fmin/max. > > gcc/ >

Re: [PATCH, rs6000] Implemented f[min/max]_optab by xs[min/max]dp [PR103605]

Hi Haochen, Thanks for the patch, some comments are inlined. on 2022/5/9 09:54, HAO CHEN GUI wrote: > Hi, > This patch implements optab f[min/max]_optab by xs[min/max]dp on rs6000. > Tests show that outputs of xs[min/max]dp are consistent with the standard > of C99 fmin/max. > > Bootstrapped

[PATCH, rs6000] Implemented f[min/max]_optab by xs[min/max]dp [PR103605]

Hi, This patch implements optab f[min/max]_optab by xs[min/max]dp on rs6000. Tests show that outputs of xs[min/max]dp are consistent with the standard of C99 fmin/max. Bootstrapped and tested on ppc64 Linux BE and LE with no regressions. Is this okay for trunk? Any recommendations? Thanks a lo