Re: [PATCH, v2] Fortran: ordering of hidden procedure arguments [PR107441]

2022-11-04 Thread Mikael Morin
Le 03/11/2022 à 23:03, Harald Anlauf a écrit : Am 03.11.22 um 11:06 schrieb Mikael Morin: Le 02/11/2022 à 22:19, Harald Anlauf via Fortran a écrit : I do see what needs to be done in gfc_get_function_type, which seems in fact very simple.  But I get really lost in create_function_arglist when

Re: [PATCH, v2] Fortran: ordering of hidden procedure arguments [PR107441]

2022-11-03 Thread Harald Anlauf via Gcc-patches
Am 03.11.22 um 11:06 schrieb Mikael Morin: Le 02/11/2022 à 22:19, Harald Anlauf via Fortran a écrit : Am 02.11.22 um 18:20 schrieb Mikael Morin: Unfortunately no, the coarray case works, but the other problem remains. The type problem is not visible in the definition of S, it is in the

Re: [PATCH, v2] Fortran: ordering of hidden procedure arguments [PR107441]

2022-11-03 Thread Mikael Morin
Le 02/11/2022 à 22:19, Harald Anlauf via Fortran a écrit : Am 02.11.22 um 18:20 schrieb Mikael Morin: Unfortunately no, the coarray case works, but the other problem remains. The type problem is not visible in the definition of S, it is in the declaration of S's prototype in P. S is defined

Re: [PATCH, v2] Fortran: ordering of hidden procedure arguments [PR107441]

2022-11-02 Thread Harald Anlauf via Gcc-patches
Am 02.11.22 um 18:20 schrieb Mikael Morin: Unfortunately no, the coarray case works, but the other problem remains. The type problem is not visible in the definition of S, it is in the declaration of S's prototype in P. S is defined as: void s (character(kind=1)[1:_c] & restrict c,

Re: [PATCH, v2] Fortran: ordering of hidden procedure arguments [PR107441]

2022-11-02 Thread Mikael Morin
Le 31/10/2022 à 21:29, Harald Anlauf via Fortran a écrit : Hi Mikael, thanks a lot, your testcases broke my initial (and incorrect) patch in multiple ways.  I understand now that the right solution is much simpler and smaller. I've added your testcases, see attached, with a simple scan of the

Re: [PATCH, v2] Fortran: ordering of hidden procedure arguments [PR107441]

2022-10-31 Thread Harald Anlauf via Gcc-patches
Hi Mikael, thanks a lot, your testcases broke my initial (and incorrect) patch in multiple ways. I understand now that the right solution is much simpler and smaller. I've added your testcases, see attached, with a simple scan of the dump for the generated order of hidden arguments in the