On 08/25/2013 09:33 PM, Gerald Pfeifer wrote:
On Tue, 20 Aug 2013, Florian Weimer wrote:
As the libvtv reviewer, you don't need permission to commit your
changes. :-)
Actually, reviewers do need someone else's approval for their own
changes (unlike maintainers and of course not for trivial
Thank you for pointing out my error. I will commit the following patch.
-- Caroline Tice
cmt...@google.com
2013-08-26 Caroline Tice cmt...@google.com
* MAINTAINERS: Correct earliers update: Move myself from libvtv
Various Reviewers to libvtv Various Maintainers.
Index: MAINTAINERS
On Tue, 20 Aug 2013, Florian Weimer wrote:
As the libvtv reviewer, you don't need permission to commit your
changes. :-)
Actually, reviewers do need someone else's approval for their own
changes (unlike maintainers and of course not for trivial changes).
Not a biggie in this case, just wanted
On 08/20/2013 12:24 AM, Caroline Tice wrote:
Hi All,
I could really use some help here from someone who has a better
understanding of how the config/Makefile system works than I do.
In my libvtv/configure.ac file, I have:
AC_GNU_SOURCE
AC_CHECK_FUNCS([__secure_getenv])
AC_GNU_SOURCE
That fixed it, thanks! Attached is the latest patch (Florian, I will
send you the regenerated Makefile.in and configure separately).
Please review and let me know if this is OK to commit!
-- Caroline
cmt...@google.com
2013-08-20 Caroline Tice cmt...@google.com
* Makefile.am (DEFS):
On 08/20/2013 09:15 PM, Caroline Tice wrote:
That fixed it, thanks! Attached is the latest patch (Florian, I will
send you the regenerated Makefile.in and configure separately).
Please review and let me know if this is OK to commit!
As the libvtv reviewer, you don't need permission to commit
Ok, committed (with the space fix).
-- Caroline Tice
cmt...@google.com
On Tue, Aug 20, 2013 at 12:43 PM, Florian Weimer fwei...@redhat.com wrote:
On 08/20/2013 09:15 PM, Caroline Tice wrote:
That fixed it, thanks! Attached is the latest patch (Florian, I will
send you the regenerated
On 08/17/2013 12:29 AM, Caroline Tice wrote:
OK, I *think* I have done as you requested. I have to try the
environment variable before falling back on stderr (there's a program
we want to use this on that disables the ability to write to stderr).
I have added the secure_getenv stuff as you
On 08/17/2013 12:29 AM, Caroline Tice wrote:
OK, I *think* I have done as you requested. I have to try the
environment variable before falling back on stderr (there's a program
we want to use this on that disables the ability to write to stderr).
I have added the secure_getenv stuff as you
Hi All,
I could really use some help here from someone who has a better
understanding of how the config/Makefile system works than I do.
In my libvtv/configure.ac file, I have:
AC_GNU_SOURCE
AC_CHECK_FUNCS([__secure_getenv])
AC_GNU_SOURCE
AC_CHECK_FUNCS([secure_getenv])
This gets translated
OK, I *think* I have done as you requested. I have to try the
environment variable before falling back on stderr (there's a program
we want to use this on that disables the ability to write to stderr).
I have added the secure_getenv stuff as you requested. The fixed patch
is attached.
Please
On 08/12/2013 07:07 PM, Caroline Tice wrote:
The feature is supposed to be active in production code (like the
stack protector).
Okay, and it makes sense to enable this in programs that run with
different privileges than the invoking user.
If a trust transition occurred during the past
On Mon, Aug 12, 2013 at 10:07 AM, Caroline Tice cmt...@google.com wrote:
On Mon, Aug 12, 2013 at 4:15 AM, Florian Weimer fwei...@redhat.com wrote:
On 08/12/2013 12:39 AM, Caroline Tice wrote:
On Sun, Aug 11, 2013 at 1:04 PM, Florian Weimer fwei...@redhat.com
wrote:
On 08/11/2013 01:08 AM,
On Mon, Aug 12, 2013 at 4:15 AM, Florian Weimer fwei...@redhat.com wrote:
On 08/12/2013 12:39 AM, Caroline Tice wrote:
On Sun, Aug 11, 2013 at 1:04 PM, Florian Weimer fwei...@redhat.com
wrote:
On 08/11/2013 01:08 AM, Caroline Tice wrote:
OK, I have removed the attempt to use $HOME for the
On Aug 10, 2013, at 4:08 PM, Caroline Tice cmt...@google.com wrote:
OK, I have removed the attempt to use $HOME for the logs;
I've reviewed the code and don't see anything I don't like anymore, thanks for
the work.
On 08/11/2013 01:08 AM, Caroline Tice wrote:
OK, I have removed the attempt to use $HOME for the logs; they will
now either go into the directory specified by the environment variable
VTV_LOGS_DIR, or they will go into the current directory. I also
added code to use secure_getenv, rather than
OK, I have removed the attempt to use $HOME for the logs; they will
now either go into the directory specified by the environment variable
VTV_LOGS_DIR, or they will go into the current directory. I also
added code to use secure_getenv, rather than getenv, if it is
available. Is this patch ok to
On 08/09/2013 12:09 AM, Caroline Tice wrote:
+ logs_dir = getenv (VTV_LOGS_DIR);
This needs to use __secure_getenv or secure_getenv, depending on the
glibc version, so that it doesn't wreak havoc in SUID/SGID binaries (or
after other kinds of privilege transitions).
Relevant autoconf
This patch changes where the logging file mechanism in libvtv tries to
write its log files. Instead of trying to use /tmp, it now first
looks for an environment variable VTV_LOGS_DIR. If it can't find
that it looks for the environment variable HOME. If it can't find
that either, it uses the
On Aug 8, 2013, at 3:09 PM, Caroline Tice cmt...@google.com wrote:
This patch changes where the logging file mechanism in libvtv tries to
write its log files. Instead of trying to use /tmp, it now first
looks for an environment variable VTV_LOGS_DIR. If it can't find
that it looks for the
On Thu, Aug 8, 2013 at 3:26 PM, Mike Stump mikest...@comcast.net wrote:
On Aug 8, 2013, at 3:09 PM, Caroline Tice cmt...@google.com wrote:
This patch changes where the logging file mechanism in libvtv tries to
write its log files. Instead of trying to use /tmp, it now first
looks for an
On Aug 8, 2013, at 3:34 PM, Caroline Tice cmt...@google.com wrote:
On Thu, Aug 8, 2013 at 3:26 PM, Mike Stump mikest...@comcast.net wrote:
On Aug 8, 2013, at 3:09 PM, Caroline Tice cmt...@google.com wrote:
This patch changes where the logging file mechanism in libvtv tries to
write its log
22 matches
Mail list logo
