Re: [PATCH,RX] Support Bit Manipulation on Memory Operands

2012-11-08 Thread Richard Henderson
Now looking at the patch past the first hunk... +(define_insn *iorbset_reg + [(set (match_operand:SI 0 register_operand +r) + (ior:SI (match_dup 0) + (match_operand 1 const_int_operand Intso)))] + satisfies_constraint_Intso (operands[1]) + bset\\t%D1,%0 + [(set_attr

RE: [PATCH,RX] Support Bit Manipulation on Memory Operands

2012-11-07 Thread Naveen H. S
Hi, Thank you for reviewing the patch and valuable comments. You need to use match_dup instead of a matching constraint. Done. Every one that isn't explicitly invoked should have a leading * in the name. Done. Please find attached the modified patch and let me know if it's okay? Thanks

Re: [PATCH,RX] Support Bit Manipulation on Memory Operands

2012-11-07 Thread Richard Henderson
On 2012-11-07 00:51, Naveen H. S wrote: + [(set (match_operand:QI 0 rx_restricted_mem_operand =Q) + (ior:QI (match_dup 0) The output constraint is now an in-out: s/=Q/+Q/. r~

RE: [PATCH,RX] Support Bit Manipulation on Memory Operands

2012-11-07 Thread Naveen H. S
Hi, Thank you for reviewing the patch and valuable comments. The output constraint is now an in-out: s/=Q/+Q/. Done. Please find attached the modified patch and let me know if it's okay? Thanks Regards, Naveen rx_bit_insn.patch Description: rx_bit_insn.patch

[PATCH,RX] Support Bit Manipulation on Memory Operands

2012-11-06 Thread Naveen H. S
Hi, Please find attached the patch rx_bit_insn.patch which supports bit operations on memory operand. Please review the same and let me know if there should be any modifications in it. Tested with rx-elf. No new Regressions. ChangeLog 2012-11-06 Naveen H.S navee...@kpitcummins.com

Re: [PATCH,RX] Support Bit Manipulation on Memory Operands

2012-11-06 Thread Richard Henderson
On 2012-11-06 06:37, Naveen H. S wrote: +(define_insn iorbset_mem + [(set (match_operand:QI 0 rx_restricted_mem_operand =Q) + (ior:QI (match_operand:QI 1 rx_restricted_mem_operand %0) + (match_operand 2 const_int_operand Intso)))] + satisfies_constraint_Intso (operands[2])