Re: [PATCH,rs6000] Add builtins for accessing the FPSCR

2018-09-27 Thread Segher Boessenkool
Hi! On Thu, Sep 27, 2018 at 04:17:57PM -0700, Carl Love wrote: > + if (icode == CODE_FOR_rs6000_mffsl > + && rs6000_isa_flags_explicit & OPTION_MASK_SOFT_FLOAT) > +fatal_error (input_location, > + "__builtin_mffsl() not supported with -msoft-float"); Please use plain "error

Re: [PATCH,rs6000] Add builtins for accessing the FPSCR

2018-09-27 Thread Carl Love
Segher: I have addressed the various formatting and other minor issues.   I checked to see if the builtins worked with -msoft-float, which they didn't. I added checks for the -msoft-float into the functions: rs6000_expand_set_fpscr_rn_builtin(),  rs6000_expand_set_fpscr_drn_builtin(), rs6000_ex

Re: [PATCH,rs6000] Add builtins for accessing the FPSCR

2018-09-21 Thread Segher Boessenkool
Hi Carl, Sorry for the late review. On Mon, Sep 17, 2018 at 03:03:28PM -0700, Carl Love wrote: > * config/rs6000.c (rs6000_expand_mtfsb0_mtfsb1_builtin): Add. config/rs6000/rs6000.c > +RS6000_BUILTIN_X (RS6000_BUILTIN_MTFSB0, "__builtin_mtfsb0", > + RS6000_BTM_ALWAYS, > +

Re: [PATCH,rs6000] Add builtins for accessing the FPSCR

2018-09-17 Thread Carl Love
Segher: This is an updated patch to add the following builtins: __builtin_mffsl, __builtin_set_fpscr_rn, __builtin_set_fpscr_rn, __builtin_mtfsb0, __builtin_mtfsb1. I have addressed you comments with regards to the change log entries. I have also addressed the various comments about the code, fu

Re: [PATCH,rs6000] Add builtins for accessing the FPSCR

2018-08-17 Thread Segher Boessenkool
Hi Carl, On Fri, Aug 17, 2018 at 11:46:06AM -0700, Carl Love wrote: > > In addition to listing > > the builtin, I added a C style comment to describe the builtin a > > little.  I don't see any of the other builtins documented like this.  > > But I felt some explanation of the builtins were > > hel

Re: [PATCH,rs6000] Add builtins for accessing the FPSCR

2018-08-17 Thread Carl Love
GCC maintainers: > In addition to listing > the builtin, I added a C style comment to describe the builtin a > little.  I don't see any of the other builtins documented like this.  > But I felt some explanation of the builtins were > helpful.  Suggestions > on a better way to add the comments on t

[PATCH,rs6000] Add builtins for accessing the FPSCR

2018-08-17 Thread Carl Love
GCC maintainers: The following patch adds builtins to change the value of the FPSCR. Specifically, __builtin_set_fpscr_rn, __builtin_set_fpscr_drn, __builtin_mffsl, __builtin_mtfsb0, __builtin_mtfsb1. I added documentation on the builtins in extend.texi. In addition to listing the builtin, I ad