Re: [PATCH/RFC] combine: Tweak the condition of last_set invalidation

Hi! On Wed, Dec 16, 2020 at 04:49:49PM +0800, Kewen.Lin wrote: > Currently we have the check: > > if (!insn > || (value && rsp->last_set_table_tick >= label_tick_ebb_start)) > rsp->last_set_invalid = 1; > > which means if we want to record some value for some reg and > this

PING^3 [PATCH/RFC] combine: Tweak the condition of last_set invalidation

Hi, Gentle ping this: https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562015.html BR, Kewen on 2021/5/26 上午11:04, Kewen.Lin via Gcc-patches wrote: > Hi, > > Gentle ping this: > > https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562015.html > > BR, > Kewen > > on 2021/5/7 上午10

PING^2 [PATCH/RFC] combine: Tweak the condition of last_set invalidation

Hi, Gentle ping this: https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562015.html BR, Kewen on 2021/5/7 上午10:45, Kewen.Lin via Gcc-patches wrote: > Hi Segher, > >>> >>> I think this should be postponed to stage 1 though? Or is there >>> anything very urgent in it? >>> >> >> Yeah, I ag

Re: [PATCH/RFC] combine: Tweak the condition of last_set invalidation

Hi Segher, >> >> I think this should be postponed to stage 1 though? Or is there >> anything very urgent in it? >> > > Yeah, I agree that this belongs to stage1, and there isn't anything > urgent about it. Thanks for all further comments above! > Gentle ping this: https://gcc.gnu.org/piperma

Re: [PATCH/RFC] combine: Tweak the condition of last_set invalidation

Hi Segher, on 2021/1/22 上午8:30, Segher Boessenkool wrote: > Hi Ke Wen, > > On Fri, Jan 15, 2021 at 04:06:17PM +0800, Kewen.Lin wrote: >> on 2021/1/15 上午8:22, Segher Boessenkool wrote: >>> On Wed, Dec 16, 2020 at 04:49:49PM +0800, Kewen.Lin wrote: ... op regX // this regX could find wrong

Re: [PATCH/RFC] combine: Tweak the condition of last_set invalidation

Hi Ke Wen, On Fri, Jan 15, 2021 at 04:06:17PM +0800, Kewen.Lin wrote: > on 2021/1/15 上午8:22, Segher Boessenkool wrote: > > On Wed, Dec 16, 2020 at 04:49:49PM +0800, Kewen.Lin wrote: > >>... op regX // this regX could find wrong last_set below > >>regX = ... // if we think this set is va

Re: [PATCH/RFC] combine: Tweak the condition of last_set invalidation

Hi Segher, Thanks for the comments! on 2021/1/15 上午8:22, Segher Boessenkool wrote: > Hi! > > On Wed, Dec 16, 2020 at 04:49:49PM +0800, Kewen.Lin wrote: >> When I was investigating unsigned int vec_init issue on Power, >> I happened to find there seems something we can enhance in how >> combine p

Re: [PATCH/RFC] combine: Tweak the condition of last_set invalidation

Hi! On Wed, Dec 16, 2020 at 04:49:49PM +0800, Kewen.Lin wrote: > When I was investigating unsigned int vec_init issue on Power, > I happened to find there seems something we can enhance in how > combine pass invalidate last_set (set last_set_invalid nonzero). > > Currently we have the check: > >

PING^1 [PATCH/RFC] combine: Tweak the condition of last_set invalidation

Hi, I'd like to gentle ping this: https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562015.html BR, Kewen on 2020/12/16 下午4:49, Kewen.Lin via Gcc-patches wrote: > Hi, > > When I was investigating unsigned int vec_init issue on Power, > I happened to find there seems something we can enh

[PATCH/RFC] combine: Tweak the condition of last_set invalidation

Hi, When I was investigating unsigned int vec_init issue on Power, I happened to find there seems something we can enhance in how combine pass invalidate last_set (set last_set_invalid nonzero). Currently we have the check: if (!insn || (value && rsp->last_set_table_tick >= label