[PATCH/RFC v2 3/14] Add new optabs for reducing vectors to scalars

2014-09-25 Thread Alan Lawrence
Ok, so, I've tried making reduc_plus optab take two modes: that of the vector to reduce, and the result; thus allowing platforms to provide a widening reduction. However, I'm keeping reduc_[us](min|max)_optab with only a single mode, as widening makes no sense there. I've not gone as far as ma

Re: [PATCH/RFC v2 3/14] Add new optabs for reducing vectors to scalars

2014-09-25 Thread Richard Biener
On Thu, Sep 25, 2014 at 4:32 PM, Alan Lawrence wrote: > Ok, so, I've tried making reduc_plus optab take two modes: that of the > vector to reduce, and the result; thus allowing platforms to provide a > widening reduction. However, I'm keeping reduc_[us](min|max)_optab with only > a single mode, as

Re: [PATCH/RFC v2 3/14] Add new optabs for reducing vectors to scalars

2014-09-25 Thread Alan Lawrence
Well, even that C source, you'd need to be careful and ensure that the vectorized loop never went round more than once, or else the additions within the loop would be performed in 8 bits, different from the final reduction... So: original patch with updated commenting attached...Segher, is ther

Re: [PATCH/RFC v2 3/14] Add new optabs for reducing vectors to scalars

2014-09-25 Thread Segher Boessenkool
On Thu, Sep 25, 2014 at 05:12:24PM +0100, Alan Lawrence wrote: > So: original patch with updated commenting attached...Segher, is there any > chance you could test this on powerpc too? (in combination with patch 2/14, > which will need to be applied first; you can skip patch 1, and >=4.) 2+3/14,