Re: [PATCH], PR target/81550, Rewrite PowerPC loop_align test so it still tests the original target hook

2018-01-24 Thread Segher Boessenkool
On Wed, Jan 24, 2018 at 05:00:39PM -0500, Michael Meissner wrote: > Replacing 'int' with 'unsigned long' allows the test to succeed once again. I > have checked this on a big endian power8 (both 32-bit and 64-bit) and on a > little endian power8 (64-bit only), and it passes in all three

Re: [PATCH], PR target/81550, Rewrite PowerPC loop_align test so it still tests the original target hook

2018-01-24 Thread Segher Boessenkool
On Wed, Jan 24, 2018 at 03:19:00PM -0500, Michael Meissner wrote: > On Wed, Jan 24, 2018 at 12:35:38PM -0600, Segher Boessenkool wrote: > > Although, hrm, in your patch you also change "int i" to "long i"; that > > alone seems to be enough to fix everything? Could you check that please? > >

Re: [PATCH], PR target/81550, Rewrite PowerPC loop_align test so it still tests the original target hook

2018-01-24 Thread Michael Meissner
On Wed, Jan 24, 2018 at 12:35:38PM -0600, Segher Boessenkool wrote: > Hi! > > On Wed, Jan 24, 2018 at 12:27:55AM -0500, Michael Meissner wrote: > > > > As Segher and I were discussing over private IRC, the root cause of this > > bug is > > the compiler no long generates the BDNZ instruction for

Re: [PATCH], PR target/81550, Rewrite PowerPC loop_align test so it still tests the original target hook

2018-01-24 Thread Michael Meissner
On Wed, Jan 24, 2018 at 12:35:38PM -0600, Segher Boessenkool wrote: > Hi! > > On Wed, Jan 24, 2018 at 12:27:55AM -0500, Michael Meissner wrote: > > > > As Segher and I were discussing over private IRC, the root cause of this > > bug is > > the compiler no long generates the BDNZ instruction for

Re: [PATCH], PR target/81550, Rewrite PowerPC loop_align test so it still tests the original target hook

2018-01-24 Thread Segher Boessenkool
Hi! On Wed, Jan 24, 2018 at 12:27:55AM -0500, Michael Meissner wrote: > > As Segher and I were discussing over private IRC, the root cause of this bug > is > the compiler no long generates the BDNZ instruction for a count down loop, > instead it decrements the index in a GPR and does a

[PATCH], PR target/81550, Rewrite PowerPC loop_align test so it still tests the original target hook

2018-01-23 Thread Michael Meissner
The loop_align.c test has been broken for some time, since I put in patches to eliminate some debug hooks (-mno-upper-regs-{df,di,sf}) that we deemed to no longer be needed. As Segher and I were discussing over private IRC, the root cause of this bug is the compiler no long generates the BDNZ