[PATCH][AArch64] Fix ILP32 memory access

2017-06-27 Thread Wilco Dijkstra
This patch fixes a failure in gcc.target/aarch64/reload-valid-spoff.c triggered by https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01367.html - it supersedes https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01907.html as this fixes the root cause of the failure. In ILP32 all memory accesses must have

Re: [PATCH][AArch64] Fix ILP32 memory access

2017-06-27 Thread Richard Earnshaw (lists)
On 27/06/17 14:39, Wilco Dijkstra wrote: > This patch fixes a failure in gcc.target/aarch64/reload-valid-spoff.c > triggered by https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01367.html - > it supersedes https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01907.html > as this fixes the root cause of the

Re: [PATCH][AArch64] Fix ILP32 memory access

2017-06-30 Thread Andreas Schwab
On Jun 27 2017, Wilco Dijkstra wrote: > @@ -5207,6 +5209,7 @@ aarch64_print_operand (FILE *f, rtx x, int code) > > case MEM: > output_address (GET_MODE (x), XEXP (x, 0)); > + gcc_assert (GET_MODE (XEXP (x, 0)) == Pmode); > break; > > case CONST: That breaks

Re: [PATCH][AArch64] Fix ILP32 memory access

2017-07-04 Thread Wilco Dijkstra
Andreas Schwab wrote: > @@ -5207,6 +5209,7 @@ aarch64_print_operand (FILE *f, rtx x, int code) >  >    case MEM: >  output_address (GET_MODE (x), XEXP (x, 0)); > +   gcc_assert (GET_MODE (XEXP (x, 0)) == Pmode); >  break; >  >    case CONST: > That breaks a lot of gna

Re: [PATCH][AArch64] Fix ILP32 memory access

2017-07-04 Thread Andreas Schwab
On Jul 04 2017, Wilco Dijkstra wrote: > checking whether compiler driver understands Ada... no You need to fix that first. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: [PATCH][AArch64] Fix ILP32 memory access

2017-07-04 Thread Arnaud Charlet
On Tue, Jul 04, 2017 at 12:19:35PM +, Wilco Dijkstra wrote: > Andreas Schwab wrote: > > @@ -5207,6 +5209,7 @@ aarch64_print_operand (FILE *f, rtx x, int code) > >  > >    case MEM: > >  output_address (GET_MODE (x), XEXP (x, 0)); > > +   gcc_assert (GET_MODE (XEXP (x, 0)) == Pm

Re: [PATCH][AArch64] Fix ILP32 memory access

2017-07-04 Thread Ramana Radhakrishnan
On Tue, Jul 4, 2017 at 1:56 PM, Arnaud Charlet wrote: > On Tue, Jul 04, 2017 at 12:19:35PM +, Wilco Dijkstra wrote: >> Andreas Schwab wrote: >> > @@ -5207,6 +5209,7 @@ aarch64_print_operand (FILE *f, rtx x, int code) >> > >> >case MEM: >> > output_address (GET_MODE (x), XEXP (

Re: [PATCH][AArch64] Fix ILP32 memory access

2017-07-04 Thread Michael Matz
Hi, On Tue, 4 Jul 2017, Ramana Radhakrishnan wrote: > Yeah it turns out that on the machine Wilco was using, we are running > 14.04 which has a gcc 4.8 base compiler that didn't have Ada on for > AArch64. > > I think we can work around by installing a gcc-5 package and then > setting CC to gc

Re: [PATCH][AArch64] Fix ILP32 memory access

2017-07-04 Thread Wilco Dijkstra
Michael Matz wrote: > > You'll probably also have to set GNATBIND and GNATMAKE to the > appropriately suffixed variants.  Just saying, because that's what I'm > usually forgetting and end up with strange errors :) Configure seems to be able to find gnatbind/gnatmake as they are in /usr/bin. Com

Re: [PATCH][AArch64] Fix ILP32 memory access

2017-07-04 Thread Michael Matz
Hi, On Tue, 4 Jul 2017, Wilco Dijkstra wrote: > > You'll probably also have to set GNATBIND and GNATMAKE to the > > appropriately suffixed variants.  Just saying, because that's what I'm > > usually forgetting and end up with strange errors :) > > Configure seems to be able to find gnatbind/gn

Re: [PATCH][AArch64] Fix ILP32 memory access

2017-07-04 Thread Andreas Schwab
On Jul 04 2017, Wilco Dijkstra wrote: > Configure seems to be able to find gnatbind/gnatmake as they are in /usr/bin. Strange there are ada tools, but no ada compiler. Are you sure you installed all relevant ada packages? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint

Re: [PATCH][AArch64] Fix ILP32 memory access

2017-07-04 Thread Ramana Radhakrishnan
On Tue, Jul 4, 2017 at 2:53 PM, Michael Matz wrote: > Hi, > > On Tue, 4 Jul 2017, Wilco Dijkstra wrote: > >> > You'll probably also have to set GNATBIND and GNATMAKE to the >> > appropriately suffixed variants. Just saying, because that's what I'm >> > usually forgetting and end up with strange e

Re: [PATCH][AArch64] Fix ILP32 memory access

2017-07-05 Thread Andrew Pinski
On Tue, Jun 27, 2017 at 6:39 AM, Wilco Dijkstra wrote: > This patch fixes a failure in gcc.target/aarch64/reload-valid-spoff.c > triggered by https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01367.html - > it supersedes https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01907.html > as this fixes the root

Re: [PATCH][AArch64] Fix ILP32 memory access

2017-07-05 Thread Wilco Dijkstra
Andrew Pinski wrote: > > This looks related to PR 80266 in that one was crashing due to the > store pair instruction like what was reported. Yes it's the same bug. I've now finally reproduced it, it seems many stack addresses in Ada are SImode which is incorrect (and ultimately can trigger the LD