Re: [PATCH][AArch64 - v2] Simplify eh_return implementation

2016-08-10 Thread Wilco Dijkstra
I noticed it would still be a good idea to add an extra barrier in the epilog as the scheduler doesn't appear to handle aliases of frame accesses properly. This patch simplifies the handling of the EH return value. We force the use of the frame pointer so the return location is always at FP + 8

Re: [PATCH][AArch64 - v2] Simplify eh_return implementation

2016-08-23 Thread Wilco Dijkstra
Ping I noticed it would still be a good idea to add an extra barrier in the epilog as the scheduler doesn't appear to handle aliases of frame accesses properly. This patch simplifies the handling of the EH return value. We force the use of the frame pointer so the return location is always at

Re: [PATCH][AArch64 - v2] Simplify eh_return implementation

2016-08-26 Thread Jiong Wang
Wilco Dijkstra writes: > Ping > > I noticed it would still be a good idea to add an extra barrier in the epilog > as the > scheduler doesn't appear to handle aliases of frame accesses properly. > > This patch simplifies the handling of the EH return value. We force the use > of the > frame poi

Re: [PATCH][AArch64 - v2] Simplify eh_return implementation

2016-08-26 Thread Wilco Dijkstra
Jiong Wang wrote: > The -fomit-frame-pointer is really broken on aarch64_find_eh_return_addr Yes, that's a good conclusion. However even with the frame pointer there are cases that fail, for example it will access LR off SP even after alloca. In fact we're lucky it works at all sometimes... > I

Re: [PATCH][AArch64 - v2] Simplify eh_return implementation

2016-09-01 Thread Wilco Dijkstra
Ping I noticed it would still be a good idea to add an extra barrier in the epilog as the scheduler doesn't appear to handle aliases of frame accesses properly. This patch simplifies the handling of the EH return value.  We force the use of the frame pointer so the return location is always a

Re: [PATCH][AArch64 - v2] Simplify eh_return implementation

2016-09-01 Thread Ramana Radhakrishnan
On 10/08/16 17:26, Wilco Dijkstra wrote: > I noticed it would still be a good idea to add an extra barrier in the epilog > as the > scheduler doesn't appear to handle aliases of frame accesses properly. > > This patch simplifies the handling of the EH return value. We force the use > of the >