RE: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-03-04 Thread Tamar Christina
ATCH][GCC][AArch64] Have empty HWCAPs string ignored > during native feature detection > > On Mon, Mar 04, 2019 at 02:31:57PM +0100, Christophe Lyon wrote: > > The new test fails with a cross-compiler, because: > > FAIL: gcc.target/aarch64/options_set_10.c (test for excess error

Re: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-03-04 Thread Jakub Jelinek
On Mon, Mar 04, 2019 at 02:31:57PM +0100, Christophe Lyon wrote: > The new test fails with a cross-compiler, because: > FAIL: gcc.target/aarch64/options_set_10.c (test for excess errors) > Excess errors: > cc1: error: unknown value 'native' for -mcpu > > I don't know how to restrict tests to nativ

RE: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-03-04 Thread Tamar Christina
> > Sent: Wednesday, February 27, 2019 17:22 > > > To: Tamar Christina > > > Cc: Jakub Jelinek ; Kyrill Tkachov > > > ; gcc-patches@gcc.gnu.org; nd > > > ; Richard Earnshaw ; > Marcus > > > Shawcroft > > > Subject: Re: [PATCH][GCC][AArch

Re: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-03-04 Thread Christophe Lyon
atches@gcc.gnu.org; nd > > ; Richard Earnshaw ; Marcus > > Shawcroft > > Subject: Re: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored > > during native feature detection > > > > On Thu, Feb 07, 2019 at 04:43:24AM -0600, Tamar Christina wrote: > > >

RE: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-02-27 Thread Tamar Christina
Hi James, > -Original Message- > From: James Greenhalgh > Sent: Wednesday, February 27, 2019 17:22 > To: Tamar Christina > Cc: Jakub Jelinek ; Kyrill Tkachov > ; gcc-patches@gcc.gnu.org; nd > ; Richard Earnshaw ; Marcus > Shawcroft > Subject: Re: [PATCH][GCC]

Re: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-02-27 Thread James Greenhalgh
On Thu, Feb 07, 2019 at 04:43:24AM -0600, Tamar Christina wrote: > Hi All, > > Since this hasn't been reviewed yet anyway I've updated this patch to also > fix the memory leaks etc. > > -- > > This patch makes the feature detection code for AArch64 GCC not add features > automatically when the

RE: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-02-27 Thread Tamar Christina
m: gcc-patches-ow...@gcc.gnu.org > On > > Behalf Of Tamar Christina > > Sent: Wednesday, January 30, 2019 14:48 > > To: Jakub Jelinek > > Cc: Kyrill Tkachov ; > > gcc-patches@gcc.gnu.org; nd ; James Greenhalgh > > ; Richard Earnshaw > > ; Marcus Shawcrof

RE: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-02-07 Thread Tamar Christina
hes-ow...@gcc.gnu.org > On Behalf Of Tamar Christina > Sent: Wednesday, January 30, 2019 14:48 > To: Jakub Jelinek > Cc: Kyrill Tkachov ; gcc-patches@gcc.gnu.org; > nd ; James Greenhalgh ; > Richard Earnshaw ; Marcus Shawcroft > > Subject: Re: [PATCH][GCC][AArch64] Have empty

Re: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-01-30 Thread Tamar Christina
Hi Jakub, On Wed, Jan 30, 2019 at 02:06:01PM +, Tamar Christina wrote: > > Thanks for the feedback, but I think those are changes for another patch. > > At least the memory leak is something that should be fixed even in stage4 > IMNSHO. I'll provide a separate patch for this then. > Anyway,

Re: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-01-30 Thread Jakub Jelinek
On Wed, Jan 30, 2019 at 02:06:01PM +, Tamar Christina wrote: > Thanks for the feedback, but I think those are changes for another patch. At least the memory leak is something that should be fixed even in stage4 IMNSHO. Anyway, will defer to aarch64 maintainers here. Just one question, for th

Re: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-01-30 Thread Tamar Christina
Tamar From: Jakub Jelinek Sent: Wednesday, January 23, 2019 4:27:40 PM To: Kyrill Tkachov Cc: Tamar Christina; gcc-patches@gcc.gnu.org; nd; James Greenhalgh; Richard Earnshaw; Marcus Shawcroft Subject: Re: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature dete

Re: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-01-23 Thread Jakub Jelinek
On Thu, Jan 10, 2019 at 04:57:47PM +, Kyrill Tkachov wrote: > --- a/gcc/config/aarch64/driver-aarch64.c > +++ b/gcc/config/aarch64/driver-aarch64.c > @@ -253,6 +253,12 @@ host_detect_local_cpu (int argc, const char **argv) > char *p = NULL; > char *feat_string >

Re: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-01-10 Thread Kyrill Tkachov
Hi Tamar, On 18/12/18 13:36, Tamar Christina wrote: Hi All, This patch makes the feature detection code for AArch64 GCC not add features automatically when the feature had no hwcaps string to match against. This means that -mcpu=native no longer adds feature flags such as +profile. The behavio

[PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2018-12-18 Thread Tamar Christina
Hi All, This patch makes the feature detection code for AArch64 GCC not add features automatically when the feature had no hwcaps string to match against. This means that -mcpu=native no longer adds feature flags such as +profile. The behavior wasn't noticed before because at the time +profile wa