Re: [PATCH][Hashtable 3/6] Fix noexcept qualifications

2020-07-30 Thread Jonathan Wakely via Gcc-patches
On 29/07/20 11:33 +0200, François Dumont via Libstdc++ wrote: +using type4 = std::unordered_set, std::equal_to, + not_noexcept_dflt_cons_alloc>>; A couple of these tests use the wrong allocator type, which means they fail when compiled as C++20. Fixed with

Re: [PATCH][Hashtable 3/6] Fix noexcept qualifications

2020-07-30 Thread Jonathan Wakely via Gcc-patches
On 29/07/20 11:33 +0200, François Dumont via Libstdc++ wrote: I eventually committed the attached patch which consider all your remarks and moreover put back the move constructor implementation where it used to be (not inline). It limits the size of the patch. I also added comments on

Re: [PATCH][Hashtable 3/6] Fix noexcept qualifications

2020-07-29 Thread François Dumont via Gcc-patches
I eventually committed the attached patch which consider all your remarks and moreover put back the move constructor implementation where it used to be (not inline). It limits the size of the patch. I also added comments on true_type/false_type new usages like you advised on [Hashtable 0/6]

Re: [PATCH][Hashtable 3/6] Fix noexcept qualifications

2020-07-17 Thread Jonathan Wakely via Gcc-patches
On 17/11/19 21:59 +0100, François Dumont wrote: This patch adds noexcept qualification on allocator aware constructors and fix the one on the default constructor.     * include/bits/hashtable.h     (_Hashtable(_Hashtable&& __ht, __node_alloc_type&& __a, true_type)):     Add noexcept

[PATCH][Hashtable 3/6] Fix noexcept qualifications

2019-11-17 Thread François Dumont
This patch adds noexcept qualification on allocator aware constructors and fix the one on the default constructor.     * include/bits/hashtable.h     (_Hashtable(_Hashtable&& __ht, __node_alloc_type&& __a, true_type)):     Add noexcept qualification.     (_Hashtable(_Hashtable&&)): Fix noexcept