Re: [PATCH][PPC64] [PR88877]

2020-05-23 Thread Segher Boessenkool
Hi! On Mon, Mar 23, 2020 at 08:16:51PM +0530, kamlesh kumar wrote: > * rtl.h : Defined Tuple for bundling rtx, mode and > unsignedness default as 0 This line is too long (and your mailer wrapped it). No space before colon. Full stop at the end of a line. Write changelogs in the imperat

Re: [PATCH][PPC64] [PR88877]

2020-05-22 Thread kamlesh kumar via Gcc-patches
ping? On Tue, May 19, 2020 at 5:32 PM kamlesh kumar wrote: > can someone look at the patch, please? > > > On Wed, Apr 8, 2020 at 9:29 PM Jeff Law wrote: > >> On Mon, 2020-04-06 at 14:58 +0530, kamlesh kumar via Gcc-patches wrote: >> > Hi Richard, >> > Here is a discussion we did some time ago >

Re: [PATCH][PPC64] [PR88877]

2020-05-19 Thread kamlesh kumar via Gcc-patches
can someone look at the patch, please? On Wed, Apr 8, 2020 at 9:29 PM Jeff Law wrote: > On Mon, 2020-04-06 at 14:58 +0530, kamlesh kumar via Gcc-patches wrote: > > Hi Richard, > > Here is a discussion we did some time ago > > https://gcc.gnu.org/pipermail/gcc/2019-January/227834.html > > please

Re: [PATCH][PPC64] [PR88877]

2020-04-08 Thread Jeff Law via Gcc-patches
On Mon, 2020-04-06 at 14:58 +0530, kamlesh kumar via Gcc-patches wrote: > Hi Richard, > Here is a discussion we did some time ago > https://gcc.gnu.org/pipermail/gcc/2019-January/227834.html > please see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88877 for more > info regarding the bug. > > We i

Re: [PATCH][PPC64] [PR88877]

2020-04-07 Thread Segher Boessenkool
On Mon, Apr 06, 2020 at 11:46:17AM +0530, kamlesh kumar wrote: > Segher, > Please provide your suggestion/thought on the fix. Why me? I cannot approve almost all of this patch. It is huge. It is stage 1 so patches like this should not be submitted at all now (you can ask for people to look at i

Re: [PATCH][PPC64] [PR88877]

2020-04-06 Thread kamlesh kumar via Gcc-patches
Hi Richard, Here is a discussion we did some time ago https://gcc.gnu.org/pipermail/gcc/2019-January/227834.html please see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88877 for more info regarding the bug. We incorporated below Jakub's suggestion in this patch. Jakub wrote: "" Yeah, all the cal

Re: [PATCH][PPC64] [PR88877]

2020-04-06 Thread Richard Biener
On Mon, 6 Apr 2020, kamlesh kumar wrote: > Segher, > Please provide your suggestion/thought on the fix. There is not a single line of explanation what the change does so what do you expect? Richard. > On Mon, Mar 23, 2020 at 8:16 PM kamlesh kumar wrote: > > > > Attached patch fixes. > > https:

Re: [PATCH][PPC64] [PR88877]

2020-04-05 Thread kamlesh kumar via Gcc-patches
Segher, Please provide your suggestion/thought on the fix. On Mon, Mar 23, 2020 at 8:16 PM kamlesh kumar wrote: > > Attached patch fixes. > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88877. > ChangeLog Entry. > > 2020-03-23 Kamlesh Kumar > > * rtl.h : Defined Tuple for bundling rtx,

Re: [PATCH][PPC64] [PR88877]

2020-03-24 Thread kamlesh kumar via Gcc-patches
Thanks Hans-Peter for reviewing. Here is Formatted ChangeLog Entry. 2020-03-24 Kamlesh Kumar * rtl.h: Defined Tuple for bundling rtx, mode and unsignedness (default as 0), Added Extra argument (unsignedp) in emit_library_call and emit_library_call_value. * except.c: Likewise. * explow.c: Likew

Re: [PATCH][PPC64] [PR88877]

2020-03-24 Thread Hans-Peter Nilsson
On Tue, 24 Mar 2020, Hans-Peter Nilsson wrote: > The new argument is default 0, so make use of that: do not patch > all those files where 0 is fine. Oops, I was tricked by the comment; it's not actually "default 0" in the C++ sense. And you have an overloaded function with different numbers of

Re: [PATCH][PPC64] [PR88877]

2020-03-24 Thread Hans-Peter Nilsson
Please excuse some cheap points: On Mon, 23 Mar 2020, kamlesh kumar via Gcc-patches wrote: > Attached patch fixes. > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88877. > ChangeLog Entry. > > 2020-03-23 Kamlesh Kumar > > * rtl.h : Defined Tuple for bundling rtx, mode and > unsignedness

[PATCH][PPC64] [PR88877]

2020-03-23 Thread kamlesh kumar via Gcc-patches
Attached patch fixes. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88877. ChangeLog Entry. 2020-03-23 Kamlesh Kumar * rtl.h : Defined Tuple for bundling rtx, mode and unsignedness default as 0 Added Extra argument (unsignedp) in emit_library_call and emit_library_call_value.