[PATCH][RFA/RFC] Stack clash mitigation patch 08/08 - V3

2017-07-30 Thread Jeff Law
These are the s390 patches for stack clash mitigation. Changes since V2: Incorporate changes from IBM to address missing functionality. Hopefully no longer regresses Ada as we no longer define STACK_CHECK_STATIC_BUILTIN. Jeff * config/s390/s390.c (MIN_UNROLL_PROBES): Define.

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 08/08 V2

2017-07-23 Thread Jeff Law
On 07/21/2017 07:23 AM, Andreas Krebbel wrote: > Hi, > > I've used your patch as the base and applied my changes on top. The > attached patch is the result, so it is supposed to replace your > version. It now also supports emitting a runtime loop. > > It bootstraps fine but unfortunately I see

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 08/08 V2

2017-07-21 Thread Jeff Law
On 07/21/2017 07:23 AM, Andreas Krebbel wrote: > Hi, > > I've used your patch as the base and applied my changes on top. The > attached patch is the result, so it is supposed to replace your > version. It now also supports emitting a runtime loop. Thanks a ton! I'll roll your changes into the

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 08/08 V2

2017-07-21 Thread Andreas Krebbel
Hi, I've used your patch as the base and applied my changes on top. The attached patch is the result, so it is supposed to replace your version. It now also supports emitting a runtime loop. It bootstraps fine but unfortunately I see an Ada regression which I haven't tracked down yet. > FAIL:

[PATCH][RFA/RFC] Stack clash mitigation patch 08/08 V2

2017-07-18 Thread Jeff Law
I don't think this patch has changed in any significant way since the V1 patch. I have tested a slightly different version which punts stack clash protection for very large static stack frames -- otherwise tests which have *huge* frames will timeout, run out of memory during compilation, etc. --

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 08/08

2017-07-14 Thread Jeff Law
On 07/14/2017 08:29 AM, Andreas Krebbel wrote: > On 07/11/2017 11:21 PM, Jeff Law wrote: >> This patch adds s390 support for stack-clash mitigation. >> >> s390's most interesting property is that the caller allocates space for >> the callee to save registers into. >> >> So much like aarch64, we

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 08/08

2017-07-14 Thread Andreas Krebbel
On 07/11/2017 11:21 PM, Jeff Law wrote: > This patch adds s390 support for stack-clash mitigation. > > s390's most interesting property is that the caller allocates space for > the callee to save registers into. > > So much like aarch64, we start with a very conservative assumption about > the

[PATCH][RFA/RFC] Stack clash mitigation patch 08/08

2017-07-11 Thread Jeff Law
This patch adds s390 support for stack-clash mitigation. s390's most interesting property is that the caller allocates space for the callee to save registers into. So much like aarch64, we start with a very conservative assumption about the offset between SP and the most recent stack probe. As