Re: [PATCH][RFC] Introduce TREE_AOREFWRAP to cache ao_ref in the IL

2021-10-18 Thread Richard Biener via Gcc-patches
On Mon, 18 Oct 2021, Michael Matz wrote: > Hello, > > On Mon, 18 Oct 2021, Richard Sandiford wrote: > > > > (It's a really cute hack that works as a micro optimization, the question > > > is, do we really need to go there already, are all other less hacky > > > approaches not bringing similar

Re: [PATCH][RFC] Introduce TREE_AOREFWRAP to cache ao_ref in the IL

2021-10-18 Thread Michael Matz via Gcc-patches
Hello, On Mon, 18 Oct 2021, Richard Sandiford wrote: > > (It's a really cute hack that works as a micro optimization, the question > > is, do we really need to go there already, are all other less hacky > > approaches not bringing similar improvements? The cuter the hacks the > > less often

Re: [PATCH][RFC] Introduce TREE_AOREFWRAP to cache ao_ref in the IL

2021-10-18 Thread Richard Sandiford via Gcc-patches
Michael Matz via Gcc-patches writes: > Hello, > > On Thu, 14 Oct 2021, Richard Biener wrote: > >> > So, at _this_ write-through of the email I think I like the above idea >> > best: make ao_ref be a tree (at least its storage, because it currently >> > is a one-member-function class), make

Re: [PATCH][RFC] Introduce TREE_AOREFWRAP to cache ao_ref in the IL

2021-10-14 Thread Michael Matz via Gcc-patches
Hello, On Thu, 14 Oct 2021, Richard Biener wrote: > > So, at _this_ write-through of the email I think I like the above idea > > best: make ao_ref be a tree (at least its storage, because it currently > > is a one-member-function class), make ao_ref.volatile_p be > > tree_base.volatile_flag

Re: [PATCH][RFC] Introduce TREE_AOREFWRAP to cache ao_ref in the IL

2021-10-14 Thread Richard Biener via Gcc-patches
On Wed, 13 Oct 2021, Michael Matz wrote: > Hello, > > [this is the fourth attempt to write a comment/review/opinion for this > ao_ref-in-tcc_reference, please accept some possible incoherence] > > On Tue, 12 Oct 2021, Richard Biener via Gcc-patches wrote: > > > This prototype hack introduces

Re: [PATCH][RFC] Introduce TREE_AOREFWRAP to cache ao_ref in the IL

2021-10-13 Thread Michael Matz via Gcc-patches
Hello, [this is the fourth attempt to write a comment/review/opinion for this ao_ref-in-tcc_reference, please accept some possible incoherence] On Tue, 12 Oct 2021, Richard Biener via Gcc-patches wrote: > This prototype hack introduces a new tcc_reference TREE_AOREFWRAP > which we can use to

[PATCH][RFC] Introduce TREE_AOREFWRAP to cache ao_ref in the IL

2021-10-12 Thread Richard Biener via Gcc-patches
This prototype hack introduces a new tcc_reference TREE_AOREFWRAP which we can use to wrap a reference tree, recording the ao_ref associated with it. That comes in handy when trying to optimize the constant factor involved with alias stmt walking (or alias queries in general) where there's