Re: [PATCH][ada][PR65490] Fix bzero warning in child_setup_tty

2015-03-31 Thread Arnaud Charlet
> > - /* ensure that s is filled with 0 */ > > - bzero (&s, sizeof (&s)); > > + /* Ensure that s is filled with 0. */ > > Please keep the comment as is, we do not put dots on single partial sentences > (otherwise you would have to change these everywhere, and you and I do not > really want tha

Re: [PATCH][ada][PR65490] Fix bzero warning in child_setup_tty

2015-03-31 Thread Arnaud Charlet
> OK for stage 4/stage1? > > Thanks, > - Tom > Fix bzero warning in child_setup_tty > > 2015-03-30 Tom de Vries > > PR ada/65490 > * terminals.c (child_setup_tty): Fix warning 'argument to sizeof in > bzero call is the same expression as the destination'. > --- > gcc/ada/t

[PATCH][ada][PR65490] Fix bzero warning in child_setup_tty

2015-03-30 Thread Tom de Vries
Hi, This patch fixes the warning: ... terminals.c:1266:21: warning: argument to ‘sizeof’ in ‘bzero’ call is the same expression as the destination; did you mean to remove the addressof? [-Wsizeof-pointer-memaccess] ... bootstrapped and reg-tested on x86_64. OK for stage 4/stage1? Thanks, -