Re: [PING][PATCH][compare-elim] Fix PR rtl-optimization/82597

2017-11-19 Thread Michael Collison
Hi Jeff, No longer needed. Jakub's patch does the job. Michael Collison > On Nov 19, 2017, at 3:50 PM, Jeff Law wrote: > >> On 10/25/2017 11:54 PM, Michael Collison wrote: >> Ping. Original patch posted here: >> >> https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01317.html >

Re: [PING][PATCH][compare-elim] Fix PR rtl-optimization/82597

2017-11-19 Thread Jeff Law
On 10/25/2017 11:54 PM, Michael Collison wrote: > Ping. Original patch posted here: > > https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01317.html Is this still needed or was it addressed by the patch Jakub checked in here: 2017-11-01 Jakub Jelinek PR

Re: [PATCH][compare-elim] Fix PR rtl-optimization/82597

2017-11-01 Thread Eric Botcazou
> Oops, I thought I've removed it, but apparently I haven't; thanks for > catching it. Here is an updated patch I'll bootstrap/regtest soon. > > 2017-11-01 Jakub Jelinek > > PR rtl-optimization/82778 > PR rtl-optimization/82597 > * compare-elim.c (struct

Re: [PATCH][compare-elim] Fix PR rtl-optimization/82597

2017-11-01 Thread Jakub Jelinek
On Wed, Nov 01, 2017 at 02:49:45PM +0100, Eric Botcazou wrote: > > At least, the only spot that used to mention df_link in compare-elim.c was: > > struct df_link *ref_chain; > > ref_chain = DF_REF_CHAIN (use); > > if (!ref_chain || !ref_chain->ref > > > > || !DF_REF_INSN_INFO

Re: [PATCH][compare-elim] Fix PR rtl-optimization/82597

2017-11-01 Thread Eric Botcazou
> At least, the only spot that used to mention df_link in compare-elim.c was: > struct df_link *ref_chain; > ref_chain = DF_REF_CHAIN (use); > if (!ref_chain || !ref_chain->ref > > || !DF_REF_INSN_INFO (ref_chain->ref) || ref_chain->next != NULL) > > return false; > > rtx_insn

Re: [PATCH][compare-elim] Fix PR rtl-optimization/82597

2017-11-01 Thread Jakub Jelinek
On Wed, Nov 01, 2017 at 02:32:02PM +0100, Eric Botcazou wrote: > > 2017-10-31 Jakub Jelinek > > > > PR rtl-optimization/82778 > > PR rtl-optimization/82597 > > * compare-elim.c (struct comparison): Add in_a_setter field. > >

Re: [PATCH][compare-elim] Fix PR rtl-optimization/82597

2017-11-01 Thread Eric Botcazou
> Here is an untested patch (only tried the cmpelim_mult_uses_1.c testcase in > aarch64 cross) that does that. I don't have aarch64 boxes around for easy > trunk testing, can bootstrap/regtest it on x86_64-linux/i686-linux and > maybe powerpc64le-linux though. > > If the memset (last_setter, 0,

Re: [PATCH][compare-elim] Fix PR rtl-optimization/82597

2017-10-31 Thread Jakub Jelinek
On Tue, Oct 31, 2017 at 12:02:26PM +0100, Jakub Jelinek wrote: > 2017-10-31 Jakub Jelinek > > PR rtl-optimization/82778 > PR rtl-optimization/82597 > * compare-elim.c (struct comparison): Add in_a_setter field. >

Re: [PATCH][compare-elim] Fix PR rtl-optimization/82597

2017-10-31 Thread Jakub Jelinek
On Tue, Oct 31, 2017 at 10:35:59AM +0100, Jakub Jelinek wrote: > > 2017-10-18 Michael Collison > > > > PR rtl-optimization/82597 > > * compare-elim.c: (try_validate_parallel): Constrain operands > > of recognized insn. > > That just duplicates more of

Re: [PATCH][compare-elim] Fix PR rtl-optimization/82597

2017-10-31 Thread Jakub Jelinek
On Fri, Oct 20, 2017 at 04:10:15AM +, Michael Collison wrote: > This patch fixes an ICE on x86 because we were not constraining the operands > of a recognized insn. Bootstrapped and tested on aarch64-none-linux-gnu and > x86_64. > > Also successfully compiled the failing test cases in 82597

[PING][PATCH][compare-elim] Fix PR rtl-optimization/82597

2017-10-25 Thread Michael Collison
Ping. Original patch posted here: https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01317.html

[PATCH][compare-elim] Fix PR rtl-optimization/82597

2017-10-19 Thread Michael Collison
This patch fixes an ICE on x86 because we were not constraining the operands of a recognized insn. Bootstrapped and tested on aarch64-none-linux-gnu and x86_64. Also successfully compiled the failing test cases in 82597 and duplicate 82592. Ok for trunk? 2017-10-18 Michael Collison