Re: [PATCH][gomp4] Plugins Support in LibGOMP (Take 2)

2013-09-23 Thread Ilya Verbin
On 23 Sep 12:26, Jakub Jelinek wrote: > On Thu, Sep 19, 2013 at 08:09:04PM +0400, Michael V. Zolotukhin wrote: > > Hi Jakub, > > > > Updated patch and my answers are below. > > Ok for gomp-4_0-branch. Checked into gomp-4_0-branch by Kirill Yukhin: http://gcc.gnu.org/ml/gcc-cvs/2013-09/msg00692.h

Re: [PATCH][gomp4] Plugins Support in LibGOMP (Take 2)

2013-09-23 Thread Jakub Jelinek
On Thu, Sep 19, 2013 at 08:09:04PM +0400, Michael V. Zolotukhin wrote: > Hi Jakub, > > Updated patch and my answers are below. Ok for gomp-4_0-branch. Jakub

Re: [PATCH][gomp4] Plugins Support in LibGOMP (Take 2)

2013-09-19 Thread Michael V. Zolotukhin
Hi Jakub, Updated patch and my answers are below. > The OpenMP standard has the omp_is_initial_device () function that can be > used to query whether the code is offloaded or not. So I don't think we > need to do the logging. For the device 257 hack we of course don't return > that as true, but

Re: [PATCH][gomp4] Plugins Support in LibGOMP (Take 2)

2013-09-18 Thread Jakub Jelinek
On Wed, Sep 18, 2013 at 12:35:38PM +0400, Michael V. Zolotukhin wrote: > I merged my patch with recent changes in gomp4-branch, and the new version is > below. Also, I fixed most of your remarks - the one isn't fixed is checking > sizeof(void*)==sizeof(uintptr_t) in configure. I'll do it in the n

[PATCH][gomp4] Plugins Support in LibGOMP (Take 2)

2013-09-18 Thread Michael V. Zolotukhin
Hi Jakub, I merged my patch with recent changes in gomp4-branch, and the new version is below. Also, I fixed most of your remarks - the one isn't fixed is checking sizeof(void*)==sizeof(uintptr_t) in configure. I'll do it in the next patch. Is it ok for gomp4-branch? Also, I was thinking of ho