Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-05-09 Thread Bernhard Reutner-Fischer
On 7 May 2019 14:00:32 CEST, "Martin Liška" wrote: /The parameters is/s/parameters/parameter/ thanks,

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-05-09 Thread Martin Liška
On 5/7/19 4:44 PM, Richard Biener wrote: > On May 7, 2019 4:33:08 PM GMT+02:00, "Martin Liška" wrote: >> On 5/7/19 2:56 PM, Richard Biener wrote: >>> But that can use the existing get_hot_bb_threshold since we never >> want >>> to dump -1 in case min_count was never initialized. >> >> Yes. But the

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-05-07 Thread Richard Biener
On May 7, 2019 4:33:08 PM GMT+02:00, "Martin Liška" wrote: >On 5/7/19 2:56 PM, Richard Biener wrote: >> But that can use the existing get_hot_bb_threshold since we never >want >> to dump -1 in case min_count was never initialized. > >Yes. But the function will call: > >get_hot_bb_threshold () >{ >

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-05-07 Thread Martin Liška
On 5/7/19 2:56 PM, Richard Biener wrote: > But that can use the existing get_hot_bb_threshold since we never want > to dump -1 in case min_count was never initialized. Yes. But the function will call: get_hot_bb_threshold () { if (min_count == -1) { gcov_type t = profile_info->sum_max

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-05-07 Thread Richard Biener
On Tue, May 7, 2019 at 2:00 PM Martin Liška wrote: > > On 5/6/19 4:02 PM, Richard Biener wrote: > > On Mon, May 6, 2019 at 9:59 AM Martin Liška wrote: > >> > >> On 5/2/19 2:31 PM, Richard Biener wrote: > >>> On Mon, Apr 29, 2019 at 2:51 PM Martin Liška wrote: > > On 4/26/19 3:18 PM, Ri

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-05-07 Thread Martin Liška
On 5/6/19 4:02 PM, Richard Biener wrote: > On Mon, May 6, 2019 at 9:59 AM Martin Liška wrote: >> >> On 5/2/19 2:31 PM, Richard Biener wrote: >>> On Mon, Apr 29, 2019 at 2:51 PM Martin Liška wrote: On 4/26/19 3:18 PM, Richard Biener wrote: > On Wed, Apr 10, 2019 at 10:12 AM Martin Li

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-05-06 Thread Richard Biener
On Mon, May 6, 2019 at 9:59 AM Martin Liška wrote: > > On 5/2/19 2:31 PM, Richard Biener wrote: > > On Mon, Apr 29, 2019 at 2:51 PM Martin Liška wrote: > >> > >> On 4/26/19 3:18 PM, Richard Biener wrote: > >>> On Wed, Apr 10, 2019 at 10:12 AM Martin Liška wrote: > > On 4/9/19 3:19 PM,

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-05-06 Thread Martin Liška
On 5/2/19 2:31 PM, Richard Biener wrote: > On Mon, Apr 29, 2019 at 2:51 PM Martin Liška wrote: >> >> On 4/26/19 3:18 PM, Richard Biener wrote: >>> On Wed, Apr 10, 2019 at 10:12 AM Martin Liška wrote: On 4/9/19 3:19 PM, Jan Hubicka wrote: >> Hi. >> >> There's updated version

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-05-02 Thread Richard Biener
On Mon, Apr 29, 2019 at 2:51 PM Martin Liška wrote: > > On 4/26/19 3:18 PM, Richard Biener wrote: > > On Wed, Apr 10, 2019 at 10:12 AM Martin Liška wrote: > >> > >> On 4/9/19 3:19 PM, Jan Hubicka wrote: > Hi. > > There's updated version that supports profile quality for both counts

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-04-29 Thread Joseph Myers
On Fri, 26 Apr 2019, Richard Biener wrote: > Can you move the GIMPLE/RTL FE specific data in c_declspecs to > a substructure accessed via indirection? I guess enlarging that > isn't really what we should do. You'd move gimple_or_rtl_pass > there and make that pointer one to a struct aux_fe_data

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-04-29 Thread Martin Liška
On 4/26/19 3:18 PM, Richard Biener wrote: > On Wed, Apr 10, 2019 at 10:12 AM Martin Liška wrote: >> >> On 4/9/19 3:19 PM, Jan Hubicka wrote: Hi. There's updated version that supports profile quality for both counts and probabilities. I'm wondering whether ENTRY and EXIT BBs nee

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-04-26 Thread Richard Biener
On Wed, Apr 10, 2019 at 10:12 AM Martin Liška wrote: > > On 4/9/19 3:19 PM, Jan Hubicka wrote: > >> Hi. > >> > >> There's updated version that supports profile quality for both counts > >> and probabilities. I'm wondering whether ENTRY and EXIT BBs needs to > >> have set probability. Apparently, I

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-04-10 Thread Martin Liška
On 4/9/19 3:19 PM, Jan Hubicka wrote: >> Hi. >> >> There's updated version that supports profile quality for both counts >> and probabilities. I'm wondering whether ENTRY and EXIT BBs needs to >> have set probability. Apparently, I haven't seen any verifier that >> would complain. > > Well, you do

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-04-09 Thread Jan Hubicka
> Hi. > > There's updated version that supports profile quality for both counts > and probabilities. I'm wondering whether ENTRY and EXIT BBs needs to > have set probability. Apparently, I haven't seen any verifier that > would complain. Well, you do not need to define it but then several cases w

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-04-09 Thread Martin Liška
On 4/8/19 3:35 PM, Martin Liška wrote: > On 4/8/19 11:11 AM, Richard Biener wrote: >> On Fri, Apr 5, 2019 at 2:32 PM Martin Liška wrote: >>> >>> Hi. >>> >>> The patch adds support for profile for GIMPLE FE. That can be useful >>> in the future. >>> >>> Patch can bootstrap on x86_64-linux-gnu and s

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-04-08 Thread Martin Liška
On 4/8/19 11:11 AM, Richard Biener wrote: > On Fri, Apr 5, 2019 at 2:32 PM Martin Liška wrote: >> >> Hi. >> >> The patch adds support for profile for GIMPLE FE. That can be useful >> in the future. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be insta

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-04-08 Thread Richard Biener
On Fri, Apr 5, 2019 at 2:32 PM Martin Liška wrote: > > Hi. > > The patch adds support for profile for GIMPLE FE. That can be useful > in the future. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed after stage1 opens? Hmm, I guess to be useful w

[PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

2019-04-05 Thread Martin Liška
Hi. The patch adds support for profile for GIMPLE FE. That can be useful in the future. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed after stage1 opens? Thanks, Martin gcc/ChangeLog: 2019-04-05 Martin Liska * gimple-pretty-print.c (du