Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-26 Thread Martin Liška
On 3/22/19 11:02 PM, Joseph Myers wrote: > This one seems wrong: > >> - "-fno-strict-aliasing is used"); >> + "%<-fno-strict-aliasing is used%>"); > > (only the option name should be quoted, not "is used"). > Hi. It's fixed now. Thanks, Martin

Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-22 Thread Joseph Myers
This one seems wrong: > - "-fno-strict-aliasing is used"); > + "%<-fno-strict-aliasing is used%>"); (only the option name should be quoted, not "is used"). -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-12 Thread Martin Liška
On 3/11/19 4:51 PM, Martin Sebor wrote: > On 3/11/19 2:13 AM, Martin Liška wrote: >> Hi. >> >> The patch adds a lot of option name wrapping in string format messages. I >> added a new contrib >> script (contrib/check-internal-format-escaping.py) that is parsing gcc.pot >> file and reports >> erro

Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-11 Thread Martin Sebor
On 3/11/19 2:13 AM, Martin Liška wrote: Hi. The patch adds a lot of option name wrapping in string format messages. I added a new contrib script (contrib/check-internal-format-escaping.py) that is parsing gcc.pot file and reports errors. Patch can bootstrap on x86_64-linux-gnu and survives re

Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-11 Thread Jakub Jelinek
On Mon, Mar 11, 2019 at 02:52:18PM +0100, Martin Liška wrote: > On 3/11/19 2:32 PM, Jakub Jelinek wrote: > > On Mon, Mar 11, 2019 at 10:12:14AM +0100, Martin Liška wrote: > >> Now I understand that, thanks. > > > > %<-misr-vector-size=X%> > > and > > %<-mcache-block-size=X%> > > need similar treat

Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-11 Thread Martin Liška
On 3/11/19 2:52 PM, Martin Liška wrote: > On 3/11/19 2:32 PM, Jakub Jelinek wrote: >> On Mon, Mar 11, 2019 at 10:12:14AM +0100, Martin Liška wrote: >>> Now I understand that, thanks. >> >> %<-misr-vector-size=X%> >> and >> %<-mcache-block-size=X%> >> need similar treatment. > > Done. > >> >> I st

Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-11 Thread Martin Liška
On 3/11/19 2:32 PM, Jakub Jelinek wrote: > On Mon, Mar 11, 2019 at 10:12:14AM +0100, Martin Liška wrote: >> Now I understand that, thanks. > > %<-misr-vector-size=X%> > and > %<-mcache-block-size=X%> > need similar treatment. Done. > > I still see > %<-mcpu%>=%s Fixed. > > %<-mfpu=crypto-neo

Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-11 Thread Jakub Jelinek
On Mon, Mar 11, 2019 at 10:12:14AM +0100, Martin Liška wrote: > Now I understand that, thanks. %<-misr-vector-size=X%> and %<-mcache-block-size=X%> need similar treatment. I still see %<-mcpu%>=%s %<-mfpu=crypto-neon...%> might need to be %<-mfpu=crypto-neon%>... or just drop the ... ? %<-std=*

Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-11 Thread Martin Liška
On 3/11/19 10:05 AM, Jakub Jelinek wrote: > On Mon, Mar 11, 2019 at 09:57:36AM +0100, Martin Liška wrote: >> On 3/11/19 9:30 AM, Jakub Jelinek wrote: >>> On Mon, Mar 11, 2019 at 09:13:57AM +0100, Martin Liška wrote: The patch adds a lot of option name wrapping in string format messages. I >>>

Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-11 Thread Jakub Jelinek
On Mon, Mar 11, 2019 at 09:57:36AM +0100, Martin Liška wrote: > On 3/11/19 9:30 AM, Jakub Jelinek wrote: > > On Mon, Mar 11, 2019 at 09:13:57AM +0100, Martin Liška wrote: > >> The patch adds a lot of option name wrapping in string format messages. I > >> added a new contrib > >> script (contrib/ch

Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-11 Thread Martin Liška
On 3/11/19 9:33 AM, Jakub Jelinek wrote: > On Mon, Mar 11, 2019 at 09:30:15AM +0100, Jakub Jelinek wrote: >> Similarly >> %<-mstringop-strategy=rep%>_8byte >> or >> %<-mcpu=v8%>.30.a >> or >> %<-mfloat128%>-hardware >> look wrong. > > %<-mspfp%>_fast > > too. I guess just go through the whole pa

Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-11 Thread Martin Liška
On 3/11/19 9:30 AM, Jakub Jelinek wrote: > On Mon, Mar 11, 2019 at 09:13:57AM +0100, Martin Liška wrote: >> The patch adds a lot of option name wrapping in string format messages. I >> added a new contrib >> script (contrib/check-internal-format-escaping.py) that is parsing gcc.pot >> file and re

Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-11 Thread Jakub Jelinek
On Mon, Mar 11, 2019 at 09:30:15AM +0100, Jakub Jelinek wrote: > Similarly > %<-mstringop-strategy=rep%>_8byte > or > %<-mcpu=v8%>.30.a > or > %<-mfloat128%>-hardware > look wrong. %<-mspfp%>_fast too. I guess just go through the whole patch and look for cases where %> is not followed by [" ] an

Re: [PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-11 Thread Jakub Jelinek
On Mon, Mar 11, 2019 at 09:13:57AM +0100, Martin Liška wrote: > The patch adds a lot of option name wrapping in string format messages. I > added a new contrib > script (contrib/check-internal-format-escaping.py) that is parsing gcc.pot > file and reports > errors. > > Patch can bootstrap on x86

[PATCH][stage1] Wrap option names in gcc internal messages with %< and %>.

2019-03-11 Thread Martin Liška
Hi. The patch adds a lot of option name wrapping in string format messages. I added a new contrib script (contrib/check-internal-format-escaping.py) that is parsing gcc.pot file and reports errors. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Apart from that I built al