Hi,
Rewrite the declaration of toc_section from the source file rs6000.c to its
header file for standardizing the code.
Bootstrap and regression were done on powerpc64le-linux-gnu (LE) with no
regressions. Is it OK for trunk?
Thanks,
Bin Bin Lv
gcc/ChangeLog
2020-03-03 Bin Bin Lv
Hi!
On Tue, Mar 03, 2020 at 10:13:56AM -0600, Bin Bin Lv wrote:
> Rewrite the declaration of toc_section from the source file rs6000.c to its
> header file for standardizing the code.
> diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
> index 0faf44b..c0a6e86 100644
> --- a/gc
Hi
On 2020/3/4 上午8:33, Segher Boessenkool wrote:
Hi!
On Tue, Mar 03, 2020 at 10:13:56AM -0600, Bin Bin Lv wrote:
Rewrite the declaration of toc_section from the source file rs6000.c to its
header file for standardizing the code.
diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs
on 2020/3/4 下午3:24, binbin wrote:
> Hi
>
> On 2020/3/4 上午8:33, Segher Boessenkool wrote:
>> Hi!
>>
>> On Tue, Mar 03, 2020 at 10:13:56AM -0600, Bin Bin Lv wrote:
>>> Rewrite the declaration of toc_section from the source file rs6000.c to its
>>> header file for standardizing the code.
>>
>>> diff
Hi!
On Wed, Mar 04, 2020 at 03:24:52PM +0800, binbin wrote:
> >>+extern union GTY(()) section *toc_section;
> >
> >Why does this add "union"?
>
> If "union" is not added, it reports error showing unknown type name
> ‘section’
> in file included from ../../host-powerpc64le-unknown-linux-gnu/gcc/t
Hi!
On Wed, Mar 04, 2020 at 06:35:23PM +0800, Kewen.Lin wrote:
> Another try seems to move it into #ifndef USED_FOR_TARGET hunk.
> Since "typedef union section section" is guard by #ifndef USED_FOR_TARGET
> in coretypes.h. It can make them consistent.
Yes, that should work, good idea.
Segher
Hi Kewen and Segher,
On 2020/3/6 上午10:02, binbin wrote:
On 2020/3/4 下午6:35, Kewen.Lin wrote:
on 2020/3/4 下午3:24, binbin wrote:
Hi
On 2020/3/4 上午8:33, Segher Boessenkool wrote:
Hi!
On Tue, Mar 03, 2020 at 10:13:56AM -0600, Bin Bin Lv wrote:
Rewrite the declaration of toc_section from the s
Hi!
On Fri, Mar 06, 2020 at 10:20:08AM +0800, binbin wrote:
> OK, changed the code. Bootstrap and regression tests were done on
> powerpc64le-linux-gnu (LE) with no regressions. Thanks for your suggestion.
Yes, this is fine, approved for trunk (but add a changelog!)
And one triviality:
> ---
Hi Segher,
On 2020/3/6 下午11:25, Segher Boessenkool wrote:
Hi!
On Fri, Mar 06, 2020 at 10:20:08AM +0800, binbin wrote:
OK, changed the code. Bootstrap and regression tests were done on
powerpc64le-linux-gnu (LE) with no regressions. Thanks for your suggestion.
Yes, this is fine, approved fo
Hi Bin Bin,
On Mon, Mar 09, 2020 at 09:55:22PM +0800, binbin wrote:
> OK, removed the empty line and showed the changelog. And I found that the
> declaration in rs6000-internal.h should also be removed, right? The
> attachment is the latest patch. Thanks.
> gcc/ChangeLog
>
> 2020-03-09 Bin B
10 matches
Mail list logo
