Re: [PATCH] AArch64: Tune case-values-threshold

2021-10-20 Thread Richard Sandiford via Gcc-patches
Wilco Dijkstra writes: > Hi Richard, > >> The problem is that you're effectively asking for these values to be >> taken on faith without providing any analysis and without describing >> how you arrived at the new numbers. Did you try other values too? >> If so, how did they compare with the numbe

Re: [PATCH] AArch64: Tune case-values-threshold

2021-10-19 Thread Wilco Dijkstra via Gcc-patches
Hi Richard, > The problem is that you're effectively asking for these values to be > taken on faith without providing any analysis and without describing > how you arrived at the new numbers.  Did you try other values too? > If so, how did they compare with the numbers that you finally chose? > At

Re: [PATCH] AArch64: Tune case-values-threshold

2021-10-19 Thread Bernhard Reutner-Fischer via Gcc-patches
On 19 October 2021 15:23:58 CEST, Richard Sandiford via Gcc-patches wrote: >Wilco Dijkstra writes: >> Hi Richard, >> >>> I'm just concerned that here we're using the same explanation but with >>> different numbers. Why are the new numbers more right than the old ones >>> (especially when it com

Re: [PATCH] AArch64: Tune case-values-threshold

2021-10-19 Thread Richard Sandiford via Gcc-patches
Wilco Dijkstra writes: > Hi Richard, > >> I'm just concerned that here we're using the same explanation but with >> different numbers. Why are the new numbers more right than the old ones >> (especially when it comes to code size, where the trade-off hasn't >> really changed)? > > Like all tuning

Re: [PATCH] AArch64: Tune case-values-threshold

2021-10-19 Thread Wilco Dijkstra via Gcc-patches
Hi Richard, > I'm just concerned that here we're using the same explanation but with > different numbers.  Why are the new numbers more right than the old ones > (especially when it comes to code size, where the trade-off hasn't > really changed)? Like all tuning/costing parameters, these values

Re: [PATCH] AArch64: Tune case-values-threshold

2021-10-18 Thread Richard Sandiford via Gcc-patches
Wilco Dijkstra writes: > Tune the case-values-threshold setting for modern cores. A value of 11 > improves > SPECINT2017 by 0.2% and reduces codesize by 0.04%. With -Os use value 8 which > reduces codesize by 0.07%. > > Passes regress, OK for commit? > > ChangeLog: > > 2021-10-18 Wilco Dijkstr

[PATCH] AArch64: Tune case-values-threshold

2021-10-18 Thread Wilco Dijkstra via Gcc-patches
Tune the case-values-threshold setting for modern cores. A value of 11 improves SPECINT2017 by 0.2% and reduces codesize by 0.04%. With -Os use value 8 which reduces codesize by 0.07%. Passes regress, OK for commit? ChangeLog: 2021-10-18 Wilco Dijkstra * config/aarch64/aarch64.c (