Re: [PATCH] ARM PR68620 (ICE with FP16 on armeb)

2016-01-26 Thread Christophe Lyon
On 26 January 2016 at 14:20, Kyrill Tkachov wrote: > Hi Christophe, > > On 20/01/16 21:10, Christophe Lyon wrote: >> >> On 19 January 2016 at 15:51, Alan Lawrence >> wrote: >>> >>> On 19/01/16 11:15, Christophe Lyon wrote: >>> >> For neon_vdupn, I chose to implement neon_vdup_nv4hf and >>

Re: [PATCH] ARM PR68620 (ICE with FP16 on armeb)

2016-01-26 Thread Kyrill Tkachov
Hi Christophe, On 20/01/16 21:10, Christophe Lyon wrote: On 19 January 2016 at 15:51, Alan Lawrence wrote: On 19/01/16 11:15, Christophe Lyon wrote: For neon_vdupn, I chose to implement neon_vdup_nv4hf and neon_vdup_nv8hf instead of updating the VX iterator because I thought it was not desir

Re: [PATCH] ARM PR68620 (ICE with FP16 on armeb)

2016-01-25 Thread Christophe Lyon
On 22 January 2016 at 18:06, Alan Lawrence wrote: > On 20/01/16 21:10, Christophe Lyon wrote: >> >> On 19 January 2016 at 15:51, Alan Lawrence >> wrote: >>> >>> On 19/01/16 11:15, Christophe Lyon wrote: >>> >> For neon_vdupn, I chose to implement neon_vdup_nv4hf and >> neon_vdup_nv8hf ins

Re: [PATCH] ARM PR68620 (ICE with FP16 on armeb)

2016-01-22 Thread Alan Lawrence
On 20/01/16 21:10, Christophe Lyon wrote: On 19 January 2016 at 15:51, Alan Lawrence wrote: On 19/01/16 11:15, Christophe Lyon wrote: For neon_vdupn, I chose to implement neon_vdup_nv4hf and neon_vdup_nv8hf instead of updating the VX iterator because I thought it was not desirable to impact n

Re: [PATCH] ARM PR68620 (ICE with FP16 on armeb)

2016-01-20 Thread Christophe Lyon
On 19 January 2016 at 15:51, Alan Lawrence wrote: > On 19/01/16 11:15, Christophe Lyon wrote: > For neon_vdupn, I chose to implement neon_vdup_nv4hf and neon_vdup_nv8hf instead of updating the VX iterator because I thought it was not desirable to impact neon_vrev32. >>> >>> >>> Well

Re: [PATCH] ARM PR68620 (ICE with FP16 on armeb)

2016-01-19 Thread Alan Lawrence
On 19/01/16 11:15, Christophe Lyon wrote: For neon_vdupn, I chose to implement neon_vdup_nv4hf and neon_vdup_nv8hf instead of updating the VX iterator because I thought it was not desirable to impact neon_vrev32. Well, the same instruction will suffice for vrev32'ing vectors of HF just as well

Re: [PATCH] ARM PR68620 (ICE with FP16 on armeb)

2016-01-19 Thread Christophe Lyon
On 18 January 2016 at 20:01, Alan Lawrence wrote: > Thanks for working on this, Christophe, and sorry I missed the PR. You got > further in fixing more things than I did though :). A couple of comments: > >> For the vec_set_internal and neon_vld1_dup patterns, I >> switched to an existing iterator

Re: [PATCH] ARM PR68620 (ICE with FP16 on armeb)

2016-01-18 Thread Alan Lawrence
Thanks for working on this, Christophe, and sorry I missed the PR. You got further in fixing more things than I did though :). A couple of comments: > For the vec_set_internal and neon_vld1_dup patterns, I > switched to an existing iterator which already had the needed > V4HF/V8HF (so I switched t

[PATCH] ARM PR68620 (ICE with FP16 on armeb)

2016-01-15 Thread Christophe Lyon
Hi, The attached patch fixes PR68620. It wasn't sufficient to add the movv4hf pattern, because this also enabled other transformations, and I had to update existing support such that the tests continue to pass after using new code paths. I added V4HF/V8HF to the VQXMOV and VDQ iterators to enabl