Re: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-07 Thread Eric Botcazou
> Please excuse my ignorance as this is my first (and hopefully not last) > patch submission.. But I don't see any testcases in the Ada testsuite except > for the (outdated) ACATS tests, which doesn't cover this assertion. So I'm > honestly not sure how I should go about that.. See testsuite/gnat.

RE: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-04 Thread Richard Wai
> -Original Message- > From: Eric Botcazou > Sent: March 4, 2020 6:18 AM > To: Richard Wai > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities > > > I'll have to look into this.. Any p

Re: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-04 Thread Eric Botcazou
> I'll have to look into this.. Any pointers? This assertion is not a language > rule assertion. Of course, neither of the 117 assertions in gcc-interface is, instead they are assertions meant to prevent wrong-code generation from occuring. > As you see, the assertion being modified already test

RE: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-03 Thread Richard Wai
Richard Wai Managing Director T. 416.316.9806 > -Original Message- > From: Eric Botcazou > Sent: March 3, 2020 3:50 PM > To: Richard Wai > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities > > >

Re: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-03 Thread Eric Botcazou
> Discovered this error when attempting to allocate from a > Root_Storage_Pool_With_Subpools derived type. If the type is derived in the > current compilation unit, and Allocate is not overridden on derivation (as > is typically the case with Root_Storage_Pool_With_Subpools), the entity for > Alloc

[PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-03 Thread Richard Wai
Hi, Discovered this error when attempting to allocate from a Root_Storage_Pool_With_Subpools derived type. If the type is derived in the current compilation unit, and Allocate is not overridden on derivation (as is typically the case with Root_Storage_Pool_With_Subpools), the entity for Allocat