On Tue, Feb 12, 2019 at 2:13 AM Martin Sebor wrote:
>
> The attached patch removes the assumption introduced earlier today
> in my fix for bug 87996 that the valid_constant_size_p argument is
> a constant expression. I couldn't come up with a C/C++ test case
> where this isn't true but
On 2/15/19 3:46 PM, Eric Botcazou wrote:
I'm ready to commit the patch once it's approved, and have been since
the day the problem was reported.
Maybe CCing whoever approved the previous patch would help?
I just pinged the patch a few minutes ago and CC'd Jason. Sorry
about any trouble this
> I'm ready to commit the patch once it's approved, and have been since
> the day the problem was reported.
Maybe CCing whoever approved the previous patch would help?
--
Eric Botcazou
Ping: https://gcc.gnu.org/ml/gcc-patches/2019-02/msg00857.html
Jason, since you approved the original patch, can you please also
review this one? Due to the Ada test breakage there seems to be
some anxiety about getting the problem corrected soon.
Thanks
Martin
On 2/11/19 6:13 PM, Martin
On 2/15/19 12:24 AM, Eric Botcazou wrote:
The attached patch removes the assumption introduced earlier today
in my fix for bug 87996 that the valid_constant_size_p argument is
a constant expression. I couldn't come up with a C/C++ test case
where this isn't true but apparently it can happen in
> The attached patch removes the assumption introduced earlier today
> in my fix for bug 87996 that the valid_constant_size_p argument is
> a constant expression. I couldn't come up with a C/C++ test case
> where this isn't true but apparently it can happen in Ada which I
> inadvertently didn't
On 2/12/19 4:43 PM, Rainer Orth wrote:
Hi Martin,
The attached patch removes the assumption introduced earlier today
in my fix for bug 87996 that the valid_constant_size_p argument is
a constant expression. I couldn't come up with a C/C++ test case
where this isn't true but apparently it can
Hi Martin,
> The attached patch removes the assumption introduced earlier today
> in my fix for bug 87996 that the valid_constant_size_p argument is
> a constant expression. I couldn't come up with a C/C++ test case
> where this isn't true but apparently it can happen in Ada which I
>
The attached patch removes the assumption introduced earlier today
in my fix for bug 87996 that the valid_constant_size_p argument is
a constant expression. I couldn't come up with a C/C++ test case
where this isn't true but apparently it can happen in Ada which I
inadvertently didn't build. I