Re: [PATCH] C++: fix fix-it hints for misspellings within explicit namespaces (v2)

2017-01-20 Thread Jason Merrill
On Thu, Jan 19, 2017 at 3:56 PM, David Malcolm wrote: > On Thu, 2017-01-19 at 13:15 -0500, Jason Merrill wrote: >> On Wed, Jan 18, 2017 at 5:29 PM, David Malcolm >> wrote: >> > Here's a version of the patch which simply tweaks >> > cp_parser_primary_expression's call to finish_id_expression so th

Re: [PATCH] C++: fix fix-it hints for misspellings within explicit namespaces (v2)

2017-01-19 Thread David Malcolm
On Thu, 2017-01-19 at 13:15 -0500, Jason Merrill wrote: > On Wed, Jan 18, 2017 at 5:29 PM, David Malcolm > wrote: > > Here's a version of the patch which simply tweaks > > cp_parser_primary_expression's call to finish_id_expression so that > > it passes the location of the id_expression, rather th

Re: [PATCH] C++: fix fix-it hints for misspellings within explicit namespaces (v2)

2017-01-19 Thread Jason Merrill
On Wed, Jan 18, 2017 at 5:29 PM, David Malcolm wrote: > Here's a version of the patch which simply tweaks > cp_parser_primary_expression's call to finish_id_expression so that > it passes the location of the id_expression, rather than that of > id_expr_token. > > The id_expression in question came

[PATCH] C++: fix fix-it hints for misspellings within explicit namespaces (v2)

2017-01-18 Thread David Malcolm
On Sat, 2017-01-14 at 09:50 -0500, Jason Merrill wrote: > On Fri, Jan 13, 2017 at 5:05 PM, David Malcolm > wrote: > > On Wed, 2017-01-04 at 14:58 -0500, Jason Merrill wrote: > > > On Tue, Jan 3, 2017 at 8:28 PM, David Malcolm < > > > dmalc...@redhat.com> > > > wrote: > > > > PR c++/77829 and PR c+

Re: [PATCH] C++: fix fix-it hints for misspellings within explicit namespaces

2017-01-14 Thread Jason Merrill
On Fri, Jan 13, 2017 at 5:05 PM, David Malcolm wrote: > On Wed, 2017-01-04 at 14:58 -0500, Jason Merrill wrote: >> On Tue, Jan 3, 2017 at 8:28 PM, David Malcolm >> wrote: >> > PR c++/77829 and PR c++/78656 identify an issue within the C++ >> > frontend >> > where it issues nonsensical fix-it hint

Re: [PATCH] C++: fix fix-it hints for misspellings within explicit namespaces

2017-01-13 Thread David Malcolm
On Wed, 2017-01-04 at 14:58 -0500, Jason Merrill wrote: > On Tue, Jan 3, 2017 at 8:28 PM, David Malcolm > wrote: > > PR c++/77829 and PR c++/78656 identify an issue within the C++ > > frontend > > where it issues nonsensical fix-it hints for misspelled name > > lookups > > within an explicitly giv

Re: [PATCH] C++: fix fix-it hints for misspellings within explicit namespaces

2017-01-04 Thread Jason Merrill
On Tue, Jan 3, 2017 at 8:28 PM, David Malcolm wrote: > PR c++/77829 and PR c++/78656 identify an issue within the C++ frontend > where it issues nonsensical fix-it hints for misspelled name lookups > within an explicitly given namespace: it finds the closest name within > all namespaces, and uses

[PATCH] C++: fix fix-it hints for misspellings within explicit namespaces

2017-01-03 Thread David Malcolm
PR c++/77829 and PR c++/78656 identify an issue within the C++ frontend where it issues nonsensical fix-it hints for misspelled name lookups within an explicitly given namespace: it finds the closest name within all namespaces, and uses the location of the namespace for the replacement, rather than