Re: [PATCH] Canonicalize compares in combine [3/3] ARM backend part

2011-07-18 Thread Richard Earnshaw
On 18/07/11 14:10, Chung-Lin Tang wrote: > On 2011/7/18 04:46 PM, Richard Earnshaw wrote: >> The patch to arm.c is ok, but the change to the test is not as it will cause >> problems with multilib testing. A better fix is to skip the test if the >> target is thumb1. >> >> The other test needs a s

Re: [PATCH] Canonicalize compares in combine [3/3] ARM backend part

2011-07-18 Thread Chung-Lin Tang
On 2011/7/18 04:46 PM, Richard Earnshaw wrote: > The patch to arm.c is ok, but the change to the test is not as it will cause > problems with multilib testing. A better fix is to skip the test if the > target is thumb1. > > The other test needs a similar check as it seems to expect a movs instr

Re: [PATCH] Canonicalize compares in combine [3/3] ARM backend part

2011-07-18 Thread Richard Earnshaw
On 18 Jul 2011, at 07:15, "Chung-Lin Tang" wrote: > On 2011/6/15 09:12 PM, Richard Earnshaw wrote: >> On 22/04/11 16:21, Chung-Lin Tang wrote: >>> Hi Richard, this part's for you. >>> >>> The ARM backend changes needed are very little after the prior patches, >>> basically just a case in arm_can

Re: [PATCH] Canonicalize compares in combine [3/3] ARM backend part

2011-07-17 Thread Chung-Lin Tang
On 2011/6/15 09:12 PM, Richard Earnshaw wrote: > On 22/04/11 16:21, Chung-Lin Tang wrote: >> Hi Richard, this part's for you. >> >> The ARM backend changes needed are very little after the prior patches, >> basically just a case in arm_canonicalize_comparison() to detect >> (zero_extend:SI (subreg:

Re: [PATCH] Canonicalize compares in combine [3/3] ARM backend part

2011-06-15 Thread Richard Earnshaw
On 22/04/11 16:21, Chung-Lin Tang wrote: > Hi Richard, this part's for you. > > The ARM backend changes needed are very little after the prior patches, > basically just a case in arm_canonicalize_comparison() to detect > (zero_extend:SI (subreg:QI (reg:SI ...) 0)), and swap it into (and:SI > (reg:

Ping Re: [PATCH] Canonicalize compares in combine [3/3] ARM backend part

2011-06-01 Thread Chung-Lin Tang
Ping. On 2011/5/9 11:02 PM, Chung-Lin Tang wrote: > Ping. > > On 04/22/2011 11:21 PM, Chung-Lin Tang wrote: >> Hi Richard, this part's for you. >> >> The ARM backend changes needed are very little after the prior patches, >> basically just a case in arm_canonicalize_comparison() to detect >> (zero

Ping Re: [PATCH] Canonicalize compares in combine [3/3] ARM backend part

2011-05-09 Thread Chung-Lin Tang
Ping. On 04/22/2011 11:21 PM, Chung-Lin Tang wrote: > Hi Richard, this part's for you. > > The ARM backend changes needed are very little after the prior patches, > basically just a case in arm_canonicalize_comparison() to detect > (zero_extend:SI (subreg:QI (reg:SI ...) 0)), and swap it into (an

[PATCH] Canonicalize compares in combine [3/3] ARM backend part

2011-04-22 Thread Chung-Lin Tang
Hi Richard, this part's for you. The ARM backend changes needed are very little after the prior patches, basically just a case in arm_canonicalize_comparison() to detect (zero_extend:SI (subreg:QI (reg:SI ...) 0)), and swap it into (and:SI (reg:SI) #255). Had we not tried the combine modification