Re: [PATCH] Check sorting of MAINTAINERS

2022-01-18 Thread Martin Liška
On 1/18/22 08:59, Thomas Schwinge wrote: Hi! On 2022-01-10T17:14:00+0100, Martin Liška wrote: The script is capable of checking if MAINTAINER names are sorted alphabetically. Irrespective of the pre-existing issue that a concept of a first and a last name doesn't exist in all cultures, and t

Re: [PATCH] Check sorting of MAINTAINERS

2022-01-17 Thread Thomas Schwinge
Hi! On 2022-01-10T17:14:00+0100, Martin Liška wrote: > The script is capable of checking if MAINTAINER names are sorted > alphabetically. Irrespective of the pre-existing issue that a concept of a first and a last name doesn't exist in all cultures, and thus sorting by the latter is questionable

Re: [PATCH] Check sorting of MAINTAINERS

2022-01-11 Thread Martin Liška
On 1/11/22 11:05, Martin Liška wrote: On 1/11/22 10:38, Jakub Jelinek wrote: On Tue, Jan 11, 2022 at 10:27:19AM +0100, Martin Liška wrote: On 1/10/22 17:14, Martin Liška wrote: Are you fine with the suggested changes? Hello. Jakub had comments so I'm sending v2 where I added few parsing exc

Re: [PATCH] Check sorting of MAINTAINERS

2022-01-11 Thread Martin Liška
On 1/11/22 10:38, Jakub Jelinek wrote: On Tue, Jan 11, 2022 at 10:27:19AM +0100, Martin Liška wrote: On 1/10/22 17:14, Martin Liška wrote: Are you fine with the suggested changes? Hello. Jakub had comments so I'm sending v2 where I added few parsing exceptions. Now it reports: I'm still su

Re: [PATCH] Check sorting of MAINTAINERS

2022-01-11 Thread Martin Liška
On 1/11/22 10:38, Jakub Jelinek wrote: That is on glibc 2.32. On glibc 2.34.9000 I get a different order though, Chêne last. Heh, that's definitely surprising. Can you raise an issue against Glibc so that we can discuss it? Thanks, Martin

Re: [PATCH] Check sorting of MAINTAINERS

2022-01-11 Thread Martin Liška
On 1/11/22 10:45, Tobias Burnus wrote: On 10.01.22 17:14, Martin Liška wrote: Are you fine with the suggested changes? I don't feel strong and having some automatic sorting is nice. But ut as a human, I note: + Kris Van Hees - Dominique d'Humieres Sorting 'Van Hees' under 'H' and 'd'Humi

Re: [PATCH] Check sorting of MAINTAINERS

2022-01-11 Thread Tobias Burnus
On 10.01.22 17:14, Martin Liška wrote: Are you fine with the suggested changes? I don't feel strong and having some automatic sorting is nice. But ut as a human, I note: + Kris Van Hees - Dominique d'Humieres Sorting 'Van Hees' under 'H' and 'd'Humieres' under 'd' feels inconsistent - I'd

Re: [PATCH] Check sorting of MAINTAINERS

2022-01-11 Thread Jakub Jelinek via Gcc-patches
On Tue, Jan 11, 2022 at 10:27:19AM +0100, Martin Liška wrote: > On 1/10/22 17:14, Martin Liška wrote: > > Are you fine with the suggested changes? > > Hello. > > Jakub had comments so I'm sending v2 where I added few parsing > exceptions. Now it reports: I'm still surprised by what the sort is d

Re: [PATCH] Check sorting of MAINTAINERS

2022-01-11 Thread Martin Liška
MartinFrom c1a2be909f550b0a820bfd0ae857cf667faba2d1 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Mon, 10 Jan 2022 16:49:31 +0100 Subject: [PATCH] Check sorting of MAINTAINERS. contrib/ChangeLog: * check-MAINTAINERS.py: New file. --- contrib/check-MAINTAINER

[PATCH] Check sorting of MAINTAINERS

2022-01-10 Thread Martin Liška
The script is capable of checking if MAINTAINER names are sorted alphabetically. I used English locales and the scripts emits: Are you fine with the suggested changes? Cheers, Martin $ contrib/check-MAINTAINERS.py MAINTAINERS Global Reviewers are fine! Wrong order for Write After Approval: M