Vogt
Date: Wed, 9 Mar 2016 15:42:23 +0100
Subject: [PATCH] Clean up tests where a later dg-do completely overrides
another.
In most tests the first dg-do could be simply removed. In one case the two
lines needed to be swapped so that the condition of the "run" was not
overridden by
On 05/02/2016 10:24 AM, Dominik Vogt wrote:
On Mon, May 02, 2016 at 09:29:50AM -0600, Jeff Law wrote:
On 04/29/2016 05:56 PM, Dominik Vogt wrote:
...
Maybe a comment should be added to the test case
/* If this test is *run* (not just compiled) and therefore fails
on non sh*-targets, this
On May 18, 2016, at 2:59 PM, Jeff Law wrote:
>
> On 05/02/2016 10:24 AM, Dominik Vogt wrote:
>> On Mon, May 02, 2016 at 09:29:50AM -0600, Jeff Law wrote:
>>> On 04/29/2016 05:56 PM, Dominik Vogt wrote:
...
Maybe a comment should be added to the test case
/* If this test is *r
On Wed, 18 May 2016, Jeff Law wrote:
> FWIW, Fedora 24 uses dejagnu-1.6. Not sure about other distributions.
openSUSE Tumbleweed is on 1.5.3, but I'm pretty sure we can get
that updated. FreeBSD Ports are at 1.6.
IMHO, go ahead.
Gerald
On 04/27/2016 09:50 AM, Dominik Vogt wrote:
The attached patch cleans up some (mostly unnecessary) dg-do
directives in the gcc.dg and gcc.target test cases.
Ok except...
* gcc.dg/spec-options.c: Switch order of the two "dg-do run" so that
the test ist actually "run" on sh*-*-*
On 04/27/2016 09:50 AM, Dominik Vogt wrote:
> The attached patch cleans up some (mostly unnecessary) dg-do
> directives in the gcc.dg and gcc.target test cases.
Applied. Thanks!
-Andreas-
Dominik Vogt writes:
> The attached patch cleans up some (mostly unnecessary) dg-do
> directives in the gcc.dg and gcc.target test cases.
This part
* gcc.dg/spec-options.c: Switch order of the two "dg-do run" so that
the test ist actually "run" on sh*-*-*. Order _does_ matter.
On Fri, Apr 29, 2016 at 10:03:40PM +0200, Rainer Orth wrote:
> Dominik Vogt writes:
>
> > The attached patch cleans up some (mostly unnecessary) dg-do
> > directives in the gcc.dg and gcc.target test cases.
>
> This part
>
> * gcc.dg/spec-options.c: Switch order of the two "dg-do run" so
Hi,
nice bug, we should not test it in the gcc testsuite.
Could you just split the spec-options.c test case in one that
compiles everywhere, and one that executes only on target sh*-*-* ?
Bernd.
On 04/29/2016 05:56 PM, Dominik Vogt wrote:
Yeah, sorry, I really should have mentioned this but forgot about
it. It's a bug in DejaGnu. When it encounters a conditional
dg-do and the condition does not match, it *still* replaces the
do-action of a prior dg-do with the current one. With DejaG
On Mon, May 02, 2016 at 09:29:50AM -0600, Jeff Law wrote:
> On 04/29/2016 05:56 PM, Dominik Vogt wrote:
> > ...
> >Maybe a comment should be added to the test case
> >
> > /* If this test is *run* (not just compiled) and therefore fails
> > on non sh*-targets, this is because of a bug older De
11 matches
Mail list logo