Re: [PATCH] Fix -Wformat-diag for rs6000 target.

2022-01-13 Thread Segher Boessenkool
Hi! On Wed, Jan 12, 2022 at 10:02:36AM +0100, Martin Liška wrote: > - error ("%qs requires ISA 3.0 IEEE 128-bit floating point", name); > + error ("%qs requires ISA 3.0 IEEE 128-bit floating-point", name); This change is incorrect. Floating point is not an adjective here. It is

Re: [PATCH] Fix -Wformat-diag for rs6000 target.

2022-01-13 Thread Martin Liška
On 1/13/22 13:55, Richard Sandiford wrote: Like you say in the linked message, we could add an explicit noun too. But the change seems OK as-is to me. May I consider it as an approval of the suggested patch? Thanks, Martin

Re: [PATCH] Fix -Wformat-diag for rs6000 target.

2022-01-13 Thread Martin Sebor via Gcc-patches
On 1/13/22 05:55, Richard Sandiford wrote: Martin Sebor via Gcc-patches writes: On 1/12/22 02:02, Martin Liška wrote: Hello. We've got -Wformat-diag for some time and I think we should start using it in -Werror for GCC bootstrap. The following patch removes last pieces of the warning for

Re: [PATCH] Fix -Wformat-diag for rs6000 target.

2022-01-13 Thread Richard Sandiford via Gcc-patches
Martin Sebor via Gcc-patches writes: > On 1/12/22 02:02, Martin Liška wrote: >> Hello. >> >> We've got -Wformat-diag for some time and I think we should start using it >> in -Werror for GCC bootstrap. The following patch removes last pieces of >> the warning >> for rs6000 target. >> >> Ready

Re: [PATCH] Fix -Wformat-diag for rs6000 target.

2022-01-12 Thread Martin Sebor via Gcc-patches
On 1/12/22 02:02, Martin Liška wrote: Hello. We've got -Wformat-diag for some time and I think we should start using it in -Werror for GCC bootstrap. The following patch removes last pieces of the warning for rs6000 target. Ready to be installed? Thanks, Martin gcc/ChangeLog: *

Re: [PATCH] Fix -Wformat-diag for rs6000 target.

2022-01-12 Thread Martin Sebor via Gcc-patches
On 1/12/22 02:02, Martin Liška wrote: Hello. We've got -Wformat-diag for some time and I think we should start using it in -Werror for GCC bootstrap. The following patch removes last pieces of the warning for rs6000 target. Ready to be installed? Thanks, Martin gcc/ChangeLog: *

[PATCH] Fix -Wformat-diag for rs6000 target.

2022-01-12 Thread Martin Liška
Hello. We've got -Wformat-diag for some time and I think we should start using it in -Werror for GCC bootstrap. The following patch removes last pieces of the warning for rs6000 target. Ready to be installed? Thanks, Martin gcc/ChangeLog: * config/rs6000/rs6000-call.c