Re: [PATCH] Fix -Wimplicit-fallthrough ICE (PR c/77946)

2016-10-14 Thread Jakub Jelinek
On Fri, Oct 14, 2016 at 11:05:22AM +0200, Bernd Schmidt wrote: > On 10/13/2016 12:27 PM, Bernd Schmidt wrote: > >On 10/13/2016 12:20 PM, Jakub Jelinek wrote: > > > >>both relied on TREE_PUBLIC be actually false for LABEL_DECLs, because > >>otherwise they have code later on that can't handle LABE_DE

Re: [PATCH] Fix -Wimplicit-fallthrough ICE (PR c/77946)

2016-10-14 Thread Bernd Schmidt
On 10/13/2016 12:27 PM, Bernd Schmidt wrote: On 10/13/2016 12:20 PM, Jakub Jelinek wrote: both relied on TREE_PUBLIC be actually false for LABEL_DECLs, because otherwise they have code later on that can't handle LABE_DECLs (plus callers also not expecting LABEL_DECLs might not bind locally or m

Re: [PATCH] Fix -Wimplicit-fallthrough ICE (PR c/77946)

2016-10-13 Thread Bernd Schmidt
On 10/13/2016 12:20 PM, Jakub Jelinek wrote: both relied on TREE_PUBLIC be actually false for LABEL_DECLs, because otherwise they have code later on that can't handle LABE_DECLs (plus callers also not expecting LABEL_DECLs might not bind locally or might not bind to the current def. Ok, thanks

Re: [PATCH] Fix -Wimplicit-fallthrough ICE (PR c/77946)

2016-10-13 Thread Jakub Jelinek
On Thu, Oct 13, 2016 at 12:11:36PM +0200, Bernd Schmidt wrote: > On 10/13/2016 01:25 AM, Jakub Jelinek wrote: > >Seems 2 functions in varasm.c just use TREE_PUBLIC on LABEL_DECLs together > >with other kinds of decls, but as TREE_PUBLIC on LABEL_DECLs means now > >something different, it breaks bad

Re: [PATCH] Fix -Wimplicit-fallthrough ICE (PR c/77946)

2016-10-13 Thread Bernd Schmidt
On 10/13/2016 01:25 AM, Jakub Jelinek wrote: Seems 2 functions in varasm.c just use TREE_PUBLIC on LABEL_DECLs together with other kinds of decls, but as TREE_PUBLIC on LABEL_DECLs means now something different, it breaks badly. Which functions are these? PR c/77946 * tree.h (

Re: [PATCH] Fix -Wimplicit-fallthrough ICE (PR c/77946)

2016-10-13 Thread Marek Polacek
On Thu, Oct 13, 2016 at 01:25:22AM +0200, Jakub Jelinek wrote: > Hi! > > Seems 2 functions in varasm.c just use TREE_PUBLIC on LABEL_DECLs together > with other kinds of decls, but as TREE_PUBLIC on LABEL_DECLs means now > something different, it breaks badly. > While I could change those 2 functi

[PATCH] Fix -Wimplicit-fallthrough ICE (PR c/77946)

2016-10-12 Thread Jakub Jelinek
Hi! Seems 2 functions in varasm.c just use TREE_PUBLIC on LABEL_DECLs together with other kinds of decls, but as TREE_PUBLIC on LABEL_DECLs means now something different, it breaks badly. While I could change those 2 functions in varasm.c, I'm afraid other functions might be doing something simila