Re: [PATCH] Fix 2 clang warnings.

2019-08-09 Thread Joseph Myers
On Sat, 29 Jun 2019, Segher Boessenkool wrote: > So I'd say that yes, void * and char * are interchangeable as arguments > to variable argument functions as well. They are explicitly interchangeable as arguments to variable argument functions using va_arg; the definition of va_arg specifies that

Re: [PATCH] Fix 2 clang warnings.

2019-06-29 Thread Segher Boessenkool
On Thu, Jun 27, 2019 at 08:49:50AM -0600, Martin Sebor wrote: > On 6/27/19 8:21 AM, Martin Liška wrote: > >/home/marxin/Programming/gcc/gcc/ggc-page.c:946:60: warning: format > >specifies type 'void *' but the argument has type 'char *' > >[-Wformat-pedantic] > > I'm normally in favor of cleanin

Re: [PATCH] Fix 2 clang warnings.

2019-06-27 Thread NightStrike
On Thu, Jun 27, 2019 at 11:16 AM Martin Sebor wrote: > > On 6/27/19 8:03 AM, Martin Liška wrote: > > Hi. > > > > This reduces 2 warnings reported by clang. > > > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > > > Ready to be installed? > > Thanks, > > Martin > > > > g

Re: [PATCH] Fix 2 clang warnings.

2019-06-27 Thread Martin Sebor
On 6/27/19 8:03 AM, Martin Liška wrote: Hi. This reduces 2 warnings reported by clang. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-06-27 Martin Liska * edit-context.c (test_applying_fixits_unread

Re: [PATCH] Fix 2 clang warnings.

2019-06-27 Thread Martin Sebor
On 6/27/19 8:21 AM, Martin Liška wrote: On 6/27/19 4:11 PM, Jakub Jelinek wrote: On Thu, Jun 27, 2019 at 04:03:06PM +0200, Martin Liška wrote: * ggc-page.c (free_page): Use (char *) for %p printf format argument. --- a/gcc/ggc-page.c +++ b/gcc/ggc-page.c @@ -977,7 +977,7 @@ f

Re: [PATCH] Fix 2 clang warnings.

2019-06-27 Thread Jakub Jelinek
On Thu, Jun 27, 2019 at 04:21:10PM +0200, Martin Liška wrote: > 2019-06-27 Martin Liska > > * edit-context.c (test_applying_fixits_unreadable_file): Do not > use () for a constructor call. > (test_applying_fixits_line_out_of_range): Likewise. > * ggc-page.c (alloc_page):

Re: [PATCH] Fix 2 clang warnings.

2019-06-27 Thread Martin Liška
specifies type 'void *' but the argument has type 'char *' [-Wformat-pedantic] entry->page, entry->page + entry->bytes - 1); ^~ Martin > > Jakub > >From 648388767ade0f7de683e79

Re: [PATCH] Fix 2 clang warnings.

2019-06-27 Thread Jakub Jelinek
On Thu, Jun 27, 2019 at 04:03:06PM +0200, Martin Liška wrote: > * ggc-page.c (free_page): Use (char *) for %p printf format > argument. > --- a/gcc/ggc-page.c > +++ b/gcc/ggc-page.c > @@ -977,7 +977,7 @@ free_page (page_entry *entry) >if (GGC_DEBUG_LEVEL >= 2) > fprintf (G.deb

[PATCH] Fix 2 clang warnings.

2019-06-27 Thread Martin Liška
Hi. This reduces 2 warnings reported by clang. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-06-27 Martin Liska * edit-context.c (test_applying_fixits_unreadable_file): Do not use () for a co