ssues, it is better
> to be safe than sorry)
>
> Honza
>
Done in patch I've just installed as r244687.
Thanks for help,
Martin
>From b0c002ba76312ba7cf38a41b1127ae8a55e89639 Mon Sep 17 00:00:00 2001
From: marxin
Date: Mon, 19 Dec 2016 11:03:34 +0100
Subject: [PATCH] Fix I
> >> 2016-12-19 Martin Liska
> >>
> >>* cgraphclones.c (cgraph_node::create_virtual_clone):
> >>Create either IPA_REF_LOAD of IPA_REF_READ depending on
> >>whether new_tree is a VAR_DECL or an ADDR_EXPR.
> >>* ipa-cp.c (create_specialized_node): Add reference just for
> >>ADD
XPR do
> IPA_REF_ADDR. Why one can not have handled component refs in there?
>
> Honza
Ok, this is updated version that I've been testing. Added a reference to PR that
we just identified that is also caused by IPA CP and will be fixed by the patch.
Thanks,
Martin
>>v
>
> 2016-12-19 Martin Liska
>
> * cgraphclones.c (cgraph_node::create_virtual_clone):
> Create either IPA_REF_LOAD of IPA_REF_READ depending on
> whether new_tree is a VAR_DECL or an ADDR_EXPR.
> * ipa-cp.c (create_specialized_node): Add reference just for
> ADDR_
PING^1
On 12/20/2016 03:55 PM, Martin Liška wrote:
On 12/20/2016 11:06 AM, Martin Jambor wrote:
...this test should be for ADDR_EXPR here. Or you could switch the
IPA_REF_* constants the other way round which I bet is going to have
the same effect in practice, but personally, I'd test for ADDR
ed (and tested in second version of the patch).
Martin
>
> Thanks,
>
> Martin
>From 2e29080e44cce899f9d5181185aba0a8a8791a9a Mon Sep 17 00:00:00 2001
From: marxin
Date: Mon, 19 Dec 2016 11:03:34 +0100
Subject: [PATCH] Fix IPA CP where it forgot to add a reference in cgraph
gcc/C
am of course fine with it, except that...
> Martin
> From 477e81fde08d0520ce552ec8baa0349590dc683c Mon Sep 17 00:00:00 2001
> From: marxin
> Date: Mon, 19 Dec 2016 11:03:34 +0100
> Subject: [PATCH] Fix IPA CP where it forgot to add a reference in cgraph
>
> gcc/ChangeLog:
Hi!
Just a nit, defer actual review to Honza or Richard.
On Mon, Dec 19, 2016 at 11:09:52AM +0100, Martin Liška wrote:
> + ipa_ref_use use_type
> + = TREE_CODE (map->new_tree) == VAR_DECL ? IPA_REF_ADDR : IPA_REF_LOAD;
= VAR_P (map->new_tree) ? IPA_REF_ADDR : IPA_REF_LOAD.
pleas
Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
Ready to be installed?
Martin
>From 477e81fde08d0520ce552ec8baa0349590dc683c Mon Sep 17 00:00:00 2001
From: marxin
Date: Mon, 19 Dec 2016 11:03:34 +0100
Subject: [PATCH] Fix IPA CP where it forgot to add a reference i
