Re: [PATCH] Fix Linux/sparc build after generic asm output optimizations.

2011-11-12 Thread David Miller
From: Eric Botcazou Date: Sun, 13 Nov 2011 00:26:51 +0100 >> Again, only those ELF targets which have an override for >> ASM_GENERATE_INTERNAL_LABEL, which if you check is almost entirely >> Sparc. > > We probably aren't looking at the same tree then. Alpha, IA-64, MIPS, HP-PA, > SPARC and a f

Re: [PATCH] Fix Linux/sparc build after generic asm output optimizations.

2011-11-12 Thread Eric Botcazou
> Again, only those ELF targets which have an override for > ASM_GENERATE_INTERNAL_LABEL, which if you check is almost entirely > Sparc. We probably aren't looking at the same tree then. Alpha, IA-64, MIPS, HP-PA, SPARC and a few others have an override for ASM_GENERATE_INTERNAL_LABEL. > The no

Re: [PATCH] Fix Linux/sparc build after generic asm output optimizations.

2011-11-12 Thread David Miller
From: Eric Botcazou Date: Sat, 12 Nov 2011 09:57:04 +0100 >> Eric, it seems that most if not all of the other ELF sparc targets >> will need something like this as well but I was only able to validate >> Linux at the moment. > > Aren't all ELF targets of all architectures potentially affected?

Re: [PATCH] Fix Linux/sparc build after generic asm output optimizations.

2011-11-12 Thread Dimitrios Apostolou
Hi, On Sat, 12 Nov 2011, Eric Botcazou wrote: We just need to declare it in system.h in order to use the definition in libiberty. OK, this should be fine. do the patches I sent for bug #51094 solve the problems? http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51094 Thanks, Dimitris

Re: [PATCH] Fix Linux/sparc build after generic asm output optimizations.

2011-11-12 Thread Eric Botcazou
> We just need to declare it in system.h in order to use the definition in > libiberty. OK, this should be fine. -- Eric Botcazou

Re: [PATCH] Fix Linux/sparc build after generic asm output optimizations.

2011-11-12 Thread Jason Merrill
On 11/12/2011 03:57 AM, Eric Botcazou wrote: And ASM_GENERATE_INTERNAL_LABEL uses stpcpy, which isn't portable. We just need to declare it in system.h in order to use the definition in libiberty. Jason

Re: [PATCH] Fix Linux/sparc build after generic asm output optimizations.

2011-11-12 Thread Eric Botcazou
> Any ELF target that overrides ASM_GENERATE_INTERNAL_LABEL is at risk > of not building any more due to the recent elfos.h changes. > > Those changes require that the label format generated by > ASM_GENERATE_INTERNAL_LABEL and TARGET_ASM_INTERNAL_LABEL are in sync, > but that is only being ensured

Re: [PATCH] Fix Linux/sparc build after generic asm output optimizations.

2011-11-11 Thread Dimitrios Apostolou
Hi David, I couldn't imagine such breakage... If too many platforms break perhaps we should undo the optimisation - see attached patch. Thanks, Dimitris P.S. see also bug #51094 I've attached some more fixes === modified file 'gcc/config/elfos.h' --- gcc/config/elfos.h 2011-10-30 01:45:46

[PATCH] Fix Linux/sparc build after generic asm output optimizations.

2011-11-11 Thread David Miller
Any ELF target that overrides ASM_GENERATE_INTERNAL_LABEL is at risk of not building any more due to the recent elfos.h changes. Those changes require that the label format generated by ASM_GENERATE_INTERNAL_LABEL and TARGET_ASM_INTERNAL_LABEL are in sync, but that is only being ensured for targe