Re: [PATCH] Fix PR78306

2016-12-02 Thread Jeff Law
On 11/30/2016 07:18 AM, Richard Biener wrote: so progess on the OMP front hides regressions elsewhere. The patch that started this thread does not have any effect on the conformance testsuite result. That makes it even more obvious that it is a) unmaintained, b) probably not used widely as th

Re: [PATCH] Fix PR78306

2016-11-30 Thread Richard Biener
On Wed, 30 Nov 2016, Andrew Senkevich wrote: > 2016-11-30 11:52 GMT+03:00 Richard Biener : > > On Tue, 29 Nov 2016, Jeff Law wrote: > > > >> On 11/29/2016 12:47 AM, Richard Biener wrote: > >> > > Balaji added this check explicitly. There should be tests in the > >> > > testsuite > >> > > (spawnee

Re: [PATCH] Fix PR78306

2016-11-30 Thread Andrew Senkevich
2016-11-30 11:52 GMT+03:00 Richard Biener : > On Tue, 29 Nov 2016, Jeff Law wrote: > >> On 11/29/2016 12:47 AM, Richard Biener wrote: >> > > Balaji added this check explicitly. There should be tests in the >> > > testsuite >> > > (spawnee_inline, spawner_inline) which exercise that code. >> > >> >

Re: [PATCH] Fix PR78306

2016-11-30 Thread Richard Biener
On Tue, 29 Nov 2016, Jeff Law wrote: > On 11/29/2016 12:47 AM, Richard Biener wrote: > > > Balaji added this check explicitly. There should be tests in the testsuite > > > (spawnee_inline, spawner_inline) which exercise that code. > > > > Yes he did, but no, nothing in the testsuite. > I believe

Re: [PATCH] Fix PR78306

2016-11-29 Thread Jeff Law
On 11/29/2016 12:47 AM, Richard Biener wrote: Balaji added this check explicitly. There should be tests in the testsuite (spawnee_inline, spawner_inline) which exercise that code. Yes he did, but no, nothing in the testsuite. I believe the tests are: c-c++-common/cilk-plus/CK/spawnee_inline.c

Re: [PATCH] Fix PR78306

2016-11-28 Thread Richard Biener
On Mon, 28 Nov 2016, Jeff Law wrote: > On 11/15/2016 07:58 AM, Richard Biener wrote: > > > > Appearantly for some unknown reason we refuse to inline anything into > > functions calling cilk_spawn. That breaks fortified headers and > > all other always-inline function calls (intrinsics come to my

Re: [PATCH] Fix PR78306

2016-11-28 Thread Jeff Law
On 11/15/2016 07:58 AM, Richard Biener wrote: Appearantly for some unknown reason we refuse to inline anything into functions calling cilk_spawn. That breaks fortified headers and all other always-inline function calls (intrinsics come to my mind as well). Bootstrapped and tested on x86_64-unk

Re: [PATCH] Fix PR78306

2016-11-16 Thread Richard Biener
On Tue, 15 Nov 2016, Richard Biener wrote: > > Appearantly for some unknown reason we refuse to inline anything into > functions calling cilk_spawn. That breaks fortified headers and > all other always-inline function calls (intrinsics come to my mind as > well). > > Bootstrapped and tested on

[PATCH] Fix PR78306

2016-11-15 Thread Richard Biener
Appearantly for some unknown reason we refuse to inline anything into functions calling cilk_spawn. That breaks fortified headers and all other always-inline function calls (intrinsics come to my mind as well). Bootstrapped and tested on x86_64-unknown-linux-gnu, ok for trunk? Thanks, Richard.