Re: [PATCH] Fix UB in dbxout.c (PR debug/84637)

2018-04-18 Thread Jeff Law
On 04/17/2018 02:54 PM, Jakub Jelinek wrote: > Hi! > > The first hunk is I think rather obvious, -2147483648 should be printed > as -2147483648 and doesn't need to introduce UB in the compiler while doing > so. The changes to stabstr_D are analogous, but in addition to that I don't > see why we

Re: [PATCH] Fix UB in dbxout.c (PR debug/84637)

2018-04-17 Thread Jim Wilson
On Tue, 2018-04-17 at 22:54 +0200, Jakub Jelinek wrote: > PR debug/84637 > * dbxout.c (dbxout_int): Perform negation in unsigned int type. > (stabstr_D): Change type of unum from unsigned int to > unsigned HOST_WIDE_INT. Perform negation in unsigned > HOST_WIDE_INT >

[PATCH] Fix UB in dbxout.c (PR debug/84637)

2018-04-17 Thread Jakub Jelinek
Hi! The first hunk is I think rather obvious, -2147483648 should be printed as -2147483648 and doesn't need to introduce UB in the compiler while doing so. The changes to stabstr_D are analogous, but in addition to that I don't see why we should just strip away the upper bits, it is again just a