Re: [PATCH] Fix __has_include error recovery in libcpp (PR preprocessor/88974)

2019-01-26 Thread Jakub Jelinek
On Fri, Jan 25, 2019 at 09:31:18AM -0500, Jason Merrill wrote: > On 1/25/19 12:15 AM, Jakub Jelinek wrote: > > On Thu, Jan 24, 2019 at 05:16:52PM -0500, Jason Merrill wrote: > > > > --- libcpp/expr.c.jj2019-01-01 12:38:16.132007335 +0100 > > > > +++ libcpp/expr.c 2019-01-24 14:07:10.08077

Re: [PATCH] Fix __has_include error recovery in libcpp (PR preprocessor/88974)

2019-01-25 Thread Jason Merrill
On 1/25/19 12:15 AM, Jakub Jelinek wrote: On Thu, Jan 24, 2019 at 05:16:52PM -0500, Jason Merrill wrote: --- libcpp/expr.c.jj2019-01-01 12:38:16.132007335 +0100 +++ libcpp/expr.c 2019-01-24 14:07:10.080774120 +0100 @@ -2238,7 +2238,9 @@ parse_has_include (cpp_reader *pfile, en

Re: [PATCH] Fix __has_include error recovery in libcpp (PR preprocessor/88974)

2019-01-24 Thread Jakub Jelinek
On Thu, Jan 24, 2019 at 05:16:52PM -0500, Jason Merrill wrote: > > --- libcpp/expr.c.jj2019-01-01 12:38:16.132007335 +0100 > > +++ libcpp/expr.c 2019-01-24 14:07:10.080774120 +0100 > > @@ -2238,7 +2238,9 @@ parse_has_include (cpp_reader *pfile, en > > XDELETEVEC (fname); > >

Re: [PATCH] Fix __has_include error recovery in libcpp (PR preprocessor/88974)

2019-01-24 Thread Jason Merrill
On 1/24/19 2:40 PM, Jakub Jelinek wrote: Hi! On the following testcase, _cpp_bracket_include -> glue_header_name emits if (token->type == CPP_EOF) { cpp_error (pfile, CPP_DL_ERROR, "missing terminating > character"); break; } which works, that last

[PATCH] Fix __has_include error recovery in libcpp (PR preprocessor/88974)

2019-01-24 Thread Jakub Jelinek
Hi! On the following testcase, _cpp_bracket_include -> glue_header_name emits if (token->type == CPP_EOF) { cpp_error (pfile, CPP_DL_ERROR, "missing terminating > character"); break; } which works, that last token has proper src_loc etc., but then parse_