Re: [PATCH] Fix always true condition in gimplify_adjust_omp_clauses

2017-08-17 Thread Richard Biener
On Thu, Aug 17, 2017 at 10:57 AM, Marek Polacek wrote: > Ping. Ok. Richard. > On Thu, Aug 10, 2017 at 08:50:44PM +0200, Marek Polacek wrote: >> My new warning triggered here and said "bitwise comparison always evaluates >> to >> true" and I believe it's right: GOVD_WRITTEN

Re: [PATCH] Fix always true condition in gimplify_adjust_omp_clauses

2017-08-17 Thread Marek Polacek
Ping. On Thu, Aug 10, 2017 at 08:50:44PM +0200, Marek Polacek wrote: > My new warning triggered here and said "bitwise comparison always evaluates to > true" and I believe it's right: GOVD_WRITTEN = 131072 which is 10... in > binary, so n->value & GOVD_WRITTEN can never be 1; I suppose 0 was

[PATCH] Fix always true condition in gimplify_adjust_omp_clauses

2017-08-10 Thread Marek Polacek
My new warning triggered here and said "bitwise comparison always evaluates to true" and I believe it's right: GOVD_WRITTEN = 131072 which is 10... in binary, so n->value & GOVD_WRITTEN can never be 1; I suppose 0 was meant to be used here instead. Too bad Jakub's away, so he can't confirm.