Re: [PATCH] Fix debug ICE on aarch64 due to bad rtl simplification (PR debug/70628)

2016-04-13 Thread Bernd Schmidt
On 04/12/2016 10:34 PM, Jakub Jelinek wrote: + return temp ? gen_rtx_fmt_ee (GET_CODE (x), to_mode, + temp, XEXP (x, 1)) + : temp; Wrap multi-line expressions in parens. No need for a full retest, just make sure the file still

Re: [PATCH] Fix debug ICE on aarch64 due to bad rtl simplification (PR debug/70628)

2016-04-13 Thread Andreas Schwab
Jakub Jelinek writes: > So here is what I'll throw at testing: > > 2016-04-12 Jakub Jelinek > > PR debug/70628 > * rtl.h (convert_memory_address_addr_space_1): New prototype. > * explow.c (convert_memory_address_addr_space_1): No longer

Re: [PATCH] Fix debug ICE on aarch64 due to bad rtl simplification (PR debug/70628)

2016-04-12 Thread Jakub Jelinek
On Tue, Apr 12, 2016 at 10:14:17PM +0200, Bernd Schmidt wrote: > >So, would you be ok with the patch if I change it that way (to be tested > >tomorrow)? > > Yeah, I think so. So here is what I'll throw at testing: 2016-04-12 Jakub Jelinek PR debug/70628 *

Re: [PATCH] Fix debug ICE on aarch64 due to bad rtl simplification (PR debug/70628)

2016-04-12 Thread Bernd Schmidt
On 04/12/2016 10:06 PM, Jakub Jelinek wrote: On Tue, Apr 12, 2016 at 10:02:18PM +0200, Bernd Schmidt wrote: On 04/12/2016 05:10 PM, Jakub Jelinek wrote: This patch arranges for a new argument to convert_memory_address_addr_space_1 and calls it with that new argument set to true, to make sure

Re: [PATCH] Fix debug ICE on aarch64 due to bad rtl simplification (PR debug/70628)

2016-04-12 Thread Jakub Jelinek
On Tue, Apr 12, 2016 at 10:02:18PM +0200, Bernd Schmidt wrote: > On 04/12/2016 05:10 PM, Jakub Jelinek wrote: > >This patch arranges for a new argument to > >convert_memory_address_addr_space_1 and calls it with that new argument set > >to true, to make sure it never emits instructions or creates

Re: [PATCH] Fix debug ICE on aarch64 due to bad rtl simplification (PR debug/70628)

2016-04-12 Thread Bernd Schmidt
On 04/12/2016 05:10 PM, Jakub Jelinek wrote: This patch arranges for a new argument to convert_memory_address_addr_space_1 and calls it with that new argument set to true, to make sure it never emits instructions or creates pseudos. I think the approach looks sensible, but I don't know if you

Re: [PATCH] Fix debug ICE on aarch64 due to bad rtl simplification (PR debug/70628)

2016-04-12 Thread H.J. Lu
On Tue, Apr 12, 2016 at 8:10 AM, Jakub Jelinek wrote: > Hi! > > Most of simplify-rtx.c attempts hard not to generate any extra instructions, > just simplify the RTL to something equivalent and let the user try to > recognize it, or whatever else it wishes. > This is especially

[PATCH] Fix debug ICE on aarch64 due to bad rtl simplification (PR debug/70628)

2016-04-12 Thread Jakub Jelinek
Hi! Most of simplify-rtx.c attempts hard not to generate any extra instructions, just simplify the RTL to something equivalent and let the user try to recognize it, or whatever else it wishes. This is especially important post-reload, when we can't create new pseudos, or e.g. when processing