RE: [PATCH] Fix for PR64081 in RTL loop unroller

2015-01-19 Thread David Edelsohn
Unfortunately this patch broke bootstrap on AIX (PPC32) PR bootstrap/64676 - David

RE: [PATCH] Fix for PR64081 in RTL loop unroller

2015-01-16 Thread Zamyatin, Igor
Not sure it's possible to merge DF_REG_DEF_CHAIN walk and DF_REF_CHAIN walk... OK. Just use the same overall structure if we can't pull the test out into a single function that could be called from both places. Thanks, is updated patch ok for trunk? Igor Changelog: gcc 2015-01-16

Re: [PATCH] Fix for PR64081 in RTL loop unroller

2015-01-16 Thread Jeff Law
On 01/16/15 08:16, Zamyatin, Igor wrote: Not sure it's possible to merge DF_REG_DEF_CHAIN walk and DF_REF_CHAIN walk... OK. Just use the same overall structure if we can't pull the test out into a single function that could be called from both places. Thanks, is updated patch ok for trunk?

Re: [PATCH] Fix for PR64081 in RTL loop unroller

2015-01-15 Thread Jeff Law
On 01/15/15 09:36, Zamyatin, Igor wrote: On 01/13/15 11:01, Zamyatin, Igor wrote: Is it really sufficient here to verify that all the defs are on latch predecessors, what about the case where there is a predecessor without a def. How do you guarantee domination in that case? ISTM that given

RE: [PATCH] Fix for PR64081 in RTL loop unroller

2015-01-15 Thread Zamyatin, Igor
On 01/13/15 11:01, Zamyatin, Igor wrote: Is it really sufficient here to verify that all the defs are on latch predecessors, what about the case where there is a predecessor without a def. How do you guarantee domination in that case? ISTM that given the structure for the code

RE: [PATCH] Fix for PR64081 in RTL loop unroller

2015-01-13 Thread Zamyatin, Igor
Is it really sufficient here to verify that all the defs are on latch predecessors, what about the case where there is a predecessor without a def. How do you guarantee domination in that case? ISTM that given the structure for the code you're writing that you'd want to verify that in

Re: [PATCH] Fix for PR64081 in RTL loop unroller

2015-01-13 Thread Jeff Law
On 01/13/15 11:01, Zamyatin, Igor wrote: Is it really sufficient here to verify that all the defs are on latch predecessors, what about the case where there is a predecessor without a def. How do you guarantee domination in that case? ISTM that given the structure for the code you're writing

Re: [PATCH] Fix for PR64081 in RTL loop unroller

2015-01-08 Thread Jeff Law
On 12/19/14 03:20, Zamyatin, Igor wrote: Hi! This is an attempt to extend RTL unroller to allow cases like mentioned in the PR - namely when loop has duplicated exit blocks and back edges. Bootstrapped and regtested on x86_64, also checking wide range of benchmarks - spec2K, spec2006, EEMBC

[PATCH] Fix for PR64081 in RTL loop unroller

2014-12-19 Thread Zamyatin, Igor
Hi! This is an attempt to extend RTL unroller to allow cases like mentioned in the PR - namely when loop has duplicated exit blocks and back edges. Bootstrapped and regtested on x86_64, also checking wide range of benchmarks - spec2K, spec2006, EEMBC Is it ok for trunk in case if no testing