Re: [PATCH] Fix gnu-versioned-namespace build

2020-10-31 Thread François Dumont via Gcc-patches
After completion of test in normal and versioned namespace mode I committed the attached patch. Note that there are still failures in versioned namespace mode do to missing symbol exports for which I'll propose an other patch. On 30/10/20 7:48 pm, Jonathan Wakely wrote: On 30/10/20 18:51

Re: [PATCH] Fix gnu-versioned-namespace build

2020-10-30 Thread Jonathan Wakely via Gcc-patches
On 30/10/20 18:51 +0100, François Dumont wrote: On 30/10/20 2:37 pm, Jonathan Wakely wrote: On 30/10/20 13:23 +, Jonathan Wakely wrote: On 30/10/20 13:59 +0100, François Dumont via Libstdc++ wrote: The gnu-versioned-namespace build is broken. The fix in charconv/floating_from_chars.cc

Re: [PATCH] Fix gnu-versioned-namespace build

2020-10-30 Thread François Dumont via Gcc-patches
On 30/10/20 2:37 pm, Jonathan Wakely wrote: On 30/10/20 13:23 +, Jonathan Wakely wrote: On 30/10/20 13:59 +0100, François Dumont via Libstdc++ wrote: The gnu-versioned-namespace build is broken. The fix in charconv/floating_from_chars.cc is quite trivial. I am not so sure about the fix

Re: [PATCH] Fix gnu-versioned-namespace build

2020-10-30 Thread Jonathan Wakely via Gcc-patches
On 30/10/20 13:38 +, Jonathan Wakely wrote: On 30/10/20 13:23 +, Jonathan Wakely wrote: On 30/10/20 13:59 +0100, François Dumont via Libstdc++ wrote: The gnu-versioned-namespace build is broken. The fix in charconv/floating_from_chars.cc is quite trivial. I am not so sure about the

Re: [PATCH] Fix gnu-versioned-namespace build

2020-10-30 Thread Jonathan Wakely via Gcc-patches
On 30/10/20 13:23 +, Jonathan Wakely wrote: On 30/10/20 13:59 +0100, François Dumont via Libstdc++ wrote: The gnu-versioned-namespace build is broken. The fix in charconv/floating_from_chars.cc is quite trivial. I am not so sure about the fix in sstream-inst.cc. The change for

Re: [PATCH] Fix gnu-versioned-namespace build

2020-10-30 Thread Jonathan Wakely via Gcc-patches
On 30/10/20 13:59 +0100, François Dumont via Libstdc++ wrote: The gnu-versioned-namespace build is broken. The fix in charconv/floating_from_chars.cc is quite trivial. I am not so sure about the fix in sstream-inst.cc. The change for src/c++20/sstream-inst.cc is OK to commit. It would

[PATCH] Fix gnu-versioned-namespace build

2020-10-30 Thread François Dumont via Gcc-patches
The gnu-versioned-namespace build is broken. The fix in charconv/floating_from_chars.cc is quite trivial. I am not so sure about the fix in sstream-inst.cc.     libstdc++: Fix gnu-version-namespace buid     libstdc++-v3/ChangeLog     * include/std/charconv (from_chars): Define only

Re: [PATCH] Fix gnu-versioned-namespace build

2019-12-11 Thread Jonathan Wakely
On 11/12/19 22:28 +0100, François Dumont wrote: On 12/11/19 9:44 PM, Jonathan Wakely wrote: On 11/12/19 21:23 +0100, François Dumont wrote: On 12/11/19 12:16 PM, Jonathan Wakely wrote: On 11/12/19 08:29 +0100, François Dumont wrote: I plan to commit this tomorrow. Note that rather than just

Re: [PATCH] Fix gnu-versioned-namespace build

2019-12-11 Thread François Dumont
On 12/11/19 9:44 PM, Jonathan Wakely wrote: On 11/12/19 21:23 +0100, François Dumont wrote: On 12/11/19 12:16 PM, Jonathan Wakely wrote: On 11/12/19 08:29 +0100, François Dumont wrote: I plan to commit this tomorrow. Note that rather than just adding the missing

Re: [PATCH] Fix gnu-versioned-namespace build

2019-12-11 Thread Jonathan Wakely
On 11/12/19 21:23 +0100, François Dumont wrote: On 12/11/19 12:16 PM, Jonathan Wakely wrote: On 11/12/19 08:29 +0100, François Dumont wrote: I plan to commit this tomorrow. Note that rather than just adding the missing _GLIBCXX_[BEGIN,END]_VERSION_NAMESPACE I also move anonymous namespace

Re: [PATCH] Fix gnu-versioned-namespace build

2019-12-11 Thread François Dumont
On 12/11/19 12:16 PM, Jonathan Wakely wrote: On 11/12/19 08:29 +0100, François Dumont wrote: I plan to commit this tomorrow. Note that rather than just adding the missing _GLIBCXX_[BEGIN,END]_VERSION_NAMESPACE I also move anonymous namespace usage outside std namespace. Let me know if it was

Re: [PATCH] Fix gnu-versioned-namespace build

2019-12-11 Thread Jonathan Wakely
On 11/12/19 08:29 +0100, François Dumont wrote: I plan to commit this tomorrow. Note that rather than just adding the missing _GLIBCXX_[BEGIN,END]_VERSION_NAMESPACE I also move anonymous namespace usage outside std namespace. Let me know if it was intentional.     * src/c++11/random.cc: Add

Re: [PATCH] Fix gnu-versioned-namespace build

2019-12-11 Thread Jonathan Wakely
On 11/12/19 11:16 +, Jonathan Wakely wrote: On 11/12/19 08:29 +0100, François Dumont wrote: I plan to commit this tomorrow. Note that rather than just adding the missing _GLIBCXX_[BEGIN,END]_VERSION_NAMESPACE I also move anonymous namespace usage outside std namespace. Let me know if it

Re: [PATCH] Fix gnu-versioned-namespace build

2019-12-11 Thread Jonathan Wakely
On 11/12/19 08:29 +0100, François Dumont wrote: I plan to commit this tomorrow. Note that rather than just adding the missing _GLIBCXX_[BEGIN,END]_VERSION_NAMESPACE I also move anonymous namespace usage outside std namespace. Let me know if it was intentional. It was intentional, why move

[PATCH] Fix gnu-versioned-namespace build

2019-12-10 Thread François Dumont
I plan to commit this tomorrow. Note that rather than just adding the missing _GLIBCXX_[BEGIN,END]_VERSION_NAMESPACE I also move anonymous namespace usage outside std namespace. Let me know if it was intentional.     * src/c++11/random.cc: Add _GLIBCXX_BEGIN_NAMESPACE_VERSION and