Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-30 Thread David Edelsohn
On Mon, Apr 30, 2018 at 3:50 AM Richard Biener wrote > On Sun, 29 Apr 2018, Richard Biener wrote: > > On April 29, 2018 1:06:47 AM GMT+02:00, David Edelsohn < dje@gmail.com> wrote: > > >Hi, Richi > > > > > >I had been using two source trees to speed the bisection and didn't > > >realize > >

Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-30 Thread Richard Biener
On Sun, 29 Apr 2018, Richard Biener wrote: > On April 29, 2018 1:06:47 AM GMT+02:00, David Edelsohn > wrote: > >Hi, Richi > > > >I had been using two source trees to speed the bisection and didn't > >realize > >that one defaulted to DWARF debugging and the other defaulted to XCOFF > >debugging,

Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-29 Thread Richard Biener
On April 29, 2018 1:06:47 AM GMT+02:00, David Edelsohn wrote: >Hi, Richi > >I had been using two source trees to speed the bisection and didn't >realize >that one defaulted to DWARF debugging and the other defaulted to XCOFF >debugging, which confused the bisection result. The -f[no-]checking >p

Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-28 Thread David Edelsohn
Hi, Richi I had been using two source trees to speed the bisection and didn't realize that one defaulted to DWARF debugging and the other defaulted to XCOFF debugging, which confused the bisection result. The -f[no-]checking patch is the culprit. Thanks, David On Sat, Apr 28, 2018 at 4:08 AM Ri

Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-28 Thread Jeff Law
On 04/28/2018 12:46 AM, Richard Biener wrote: > On Fri, 27 Apr 2018, Richard Biener wrote: > >> On Fri, 27 Apr 2018, David Edelsohn wrote: >> >>> Hi, Richi >>> >>> This patches causes a boostrap failure on AIX. Everything miscompares. >>> The code itself is the same, but the DWARF debug informati

Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-28 Thread Richard Biener
On Sat, 28 Apr 2018, Richard Biener wrote: > On Fri, 27 Apr 2018, Richard Biener wrote: > > > On Fri, 27 Apr 2018, David Edelsohn wrote: > > > > > Hi, Richi > > > > > > This patches causes a boostrap failure on AIX. Everything miscompares. > > > The code itself is the same, but the DWARF debug

Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-27 Thread Richard Biener
On Fri, 27 Apr 2018, Richard Biener wrote: > On Fri, 27 Apr 2018, David Edelsohn wrote: > > > Hi, Richi > > > > This patches causes a boostrap failure on AIX. Everything miscompares. > > The code itself is the same, but the DWARF debug information contains many > > differences. > > Does AIX us

Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-27 Thread Richard Biener
On Fri, 27 Apr 2018, David Edelsohn wrote: > Hi, Richi > > This patches causes a boostrap failure on AIX. Everything miscompares. > The code itself is the same, but the DWARF debug information contains many > differences. Does AIX use bootstrap-debug by default? I don't see how the patch can c

Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-26 Thread David Edelsohn
Hi, Richi This patches causes a boostrap failure on AIX. Everything miscompares. The code itself is the same, but the DWARF debug information contains many differences. - David

Re: [PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-26 Thread Richard Biener
On Thu, 26 Apr 2018, Richard Biener wrote: > > In PR85116 there's a loop which isn't optimized well, first because > it is not header copied. The reason is the do_while_loop_p predicate is > "strange". The following adds the natural test - whether the single > latch predecessor exits the loop.

[PATCH] Fix loop-header copying do-while loop detection (PR85116)

2018-04-26 Thread Richard Biener
In PR85116 there's a loop which isn't optimized well, first because it is not header copied. The reason is the do_while_loop_p predicate is "strange". The following adds the natural test - whether the single latch predecessor exits the loop. It also removes the check that claims that a loop hea