[PATCH] Fix loop split incorrect count and probability

2021-08-03 Thread Xionghu Luo via Gcc-patches
loop split condition is moved between loop1 and loop2, the split bb's count and probability should also be duplicated instead of (100% vs INV), secondly, the original loop1 and loop2 count need be propotional from the original loop. Regression tested pass, OK for master? diff base/loop-cond-split

Re: [PATCH] Fix loop split incorrect count and probability

2021-08-03 Thread Xionghu Luo via Gcc-patches
I' like to split this patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-August/576488.html to two patches: 0001-Fix-loop-split-incorrect-count-and-probability.patch 0002-Don-t-move-cold-code-out-of-loop-by-checking-bb-coun.patch since they are solving two different things, please help to r

Re: [PATCH] Fix loop split incorrect count and probability

2021-08-06 Thread Richard Biener via Gcc-patches
On Tue, 3 Aug 2021, Xionghu Luo wrote: > loop split condition is moved between loop1 and loop2, the split bb's > count and probability should also be duplicated instead of (100% vs INV), > secondly, the original loop1 and loop2 count need be propotional from the > original loop. > > Regression te

Re: [PATCH] Fix loop split incorrect count and probability

2021-08-08 Thread Xionghu Luo via Gcc-patches
Thanks, On 2021/8/6 19:46, Richard Biener wrote: > On Tue, 3 Aug 2021, Xionghu Luo wrote: > >> loop split condition is moved between loop1 and loop2, the split bb's >> count and probability should also be duplicated instead of (100% vs INV), >> secondly, the original loop1 and loop2 count need be

Re: [PATCH] Fix loop split incorrect count and probability

2021-08-08 Thread Feng Xue OS via Gcc-patches
dje@gmail.com Subject: Re: [PATCH] Fix loop split incorrect count and probability On Tue, 3 Aug 2021, Xionghu Luo wrote: > loop split condition is moved between loop1 and loop2, the split bb's > count and probability should also be duplicated instead of (100% vs INV), > secondly,

Re: [PATCH] Fix loop split incorrect count and probability

2021-08-10 Thread Richard Biener via Gcc-patches
On Mon, 9 Aug 2021, Xionghu Luo wrote: > Thanks, > > On 2021/8/6 19:46, Richard Biener wrote: > > On Tue, 3 Aug 2021, Xionghu Luo wrote: > > > >> loop split condition is moved between loop1 and loop2, the split bb's > >> count and probability should also be duplicated instead of (100% vs INV), >

Re: [PATCH] Fix loop split incorrect count and probability

2021-08-10 Thread Feng Xue OS via Gcc-patches
...@ucw.cz Subject: Re: [PATCH] Fix loop split incorrect count and probability On Mon, 9 Aug 2021, Xionghu Luo wrote: > Thanks, > > On 2021/8/6 19:46, Richard Biener wrote: > > On Tue, 3 Aug 2021, Xionghu Luo wrote: > > > >> loop split condition is moved between l

Re: [PATCH] Fix loop split incorrect count and probability

2021-08-11 Thread Xionghu Luo via Gcc-patches
On 2021/8/10 22:47, Richard Biener wrote: > On Mon, 9 Aug 2021, Xionghu Luo wrote: > >> Thanks, >> >> On 2021/8/6 19:46, Richard Biener wrote: >>> On Tue, 3 Aug 2021, Xionghu Luo wrote: >>> loop split condition is moved between loop1 and loop2, the split bb's count and probability sho

Re: [PATCH] Fix loop split incorrect count and probability

2021-08-11 Thread Richard Biener via Gcc-patches
On Wed, 11 Aug 2021, Xionghu Luo wrote: > > > On 2021/8/10 22:47, Richard Biener wrote: > > On Mon, 9 Aug 2021, Xionghu Luo wrote: > > > >> Thanks, > >> > >> On 2021/8/6 19:46, Richard Biener wrote: > >>> On Tue, 3 Aug 2021, Xionghu Luo wrote: > >>> > loop split condition is moved between

Re: [PATCH] Fix loop split incorrect count and probability

2021-08-11 Thread Xionghu Luo via Gcc-patches
On 2021/8/11 17:16, Richard Biener wrote: On Wed, 11 Aug 2021, Xionghu Luo wrote: On 2021/8/10 22:47, Richard Biener wrote: On Mon, 9 Aug 2021, Xionghu Luo wrote: Thanks, On 2021/8/6 19:46, Richard Biener wrote: On Tue, 3 Aug 2021, Xionghu Luo wrote: loop split condition is moved be

Re: [PATCH] Fix loop split incorrect count and probability

2021-09-22 Thread Xionghu Luo via Gcc-patches
On 2021/8/11 17:16, Richard Biener wrote: On Wed, 11 Aug 2021, Xionghu Luo wrote: On 2021/8/10 22:47, Richard Biener wrote: On Mon, 9 Aug 2021, Xionghu Luo wrote: Thanks, On 2021/8/6 19:46, Richard Biener wrote: On Tue, 3 Aug 2021, Xionghu Luo wrote: loop split condition is moved be

Re: [PATCH] Fix loop split incorrect count and probability

2021-09-23 Thread Richard Biener via Gcc-patches
On Wed, 22 Sep 2021, Xionghu Luo wrote: > > > On 2021/8/11 17:16, Richard Biener wrote: > > On Wed, 11 Aug 2021, Xionghu Luo wrote: > > > >> > >> > >> On 2021/8/10 22:47, Richard Biener wrote: > >>> On Mon, 9 Aug 2021, Xionghu Luo wrote: > >>> > Thanks, > > On 2021/8/6 19:46, Ric

Re: [PATCH] Fix loop split incorrect count and probability

2021-10-14 Thread Xionghu Luo via Gcc-patches
On 2021/9/23 20:17, Richard Biener wrote: > On Wed, 22 Sep 2021, Xionghu Luo wrote: > >> >> >> On 2021/8/11 17:16, Richard Biener wrote: >>> On Wed, 11 Aug 2021, Xionghu Luo wrote: >>> On 2021/8/10 22:47, Richard Biener wrote: > On Mon, 9 Aug 2021, Xionghu Luo wrote: > >>>

Re: [PATCH] Fix loop split incorrect count and probability

2021-10-21 Thread Xionghu Luo via Gcc-patches
On 2021/10/15 13:51, Xionghu Luo via Gcc-patches wrote: > > > On 2021/9/23 20:17, Richard Biener wrote: >> On Wed, 22 Sep 2021, Xionghu Luo wrote: >> >>> >>> >>> On 2021/8/11 17:16, Richard Biener wrote: On Wed, 11 Aug 2021, Xionghu Luo wrote: > > > On 2021/8/10 22:47, Ri

Re: [PATCH] Fix loop split incorrect count and probability

2021-10-21 Thread Richard Biener via Gcc-patches
On Thu, 21 Oct 2021, Xionghu Luo wrote: > > > On 2021/10/15 13:51, Xionghu Luo via Gcc-patches wrote: > > > > > > On 2021/9/23 20:17, Richard Biener wrote: > >> On Wed, 22 Sep 2021, Xionghu Luo wrote: > >> > >>> > >>> > >>> On 2021/8/11 17:16, Richard Biener wrote: > On Wed, 11 Aug 2021,

Re: [PATCH] Fix loop split incorrect count and probability

2021-10-25 Thread Xionghu Luo via Gcc-patches
On 2021/10/21 18:55, Richard Biener wrote: > On Thu, 21 Oct 2021, Xionghu Luo wrote: > >> >> >> On 2021/10/15 13:51, Xionghu Luo via Gcc-patches wrote: >>> >>> >>> On 2021/9/23 20:17, Richard Biener wrote: On Wed, 22 Sep 2021, Xionghu Luo wrote: > > > On 2021/8/11 17:16, Ri

Re: [PATCH] Fix loop split incorrect count and probability

2021-10-26 Thread Richard Biener via Gcc-patches
On Tue, 26 Oct 2021, Xionghu Luo wrote: > > > On 2021/10/21 18:55, Richard Biener wrote: > > On Thu, 21 Oct 2021, Xionghu Luo wrote: > > > >> > >> > >> On 2021/10/15 13:51, Xionghu Luo via Gcc-patches wrote: > >>> > >>> > >>> On 2021/9/23 20:17, Richard Biener wrote: > On Wed, 22 Sep 2021,

Re: [PATCH] Fix loop split incorrect count and probability

2021-10-26 Thread Jan Hubicka via Gcc-patches
> On Tue, 26 Oct 2021, Xionghu Luo wrote: > > > > > > > On 2021/10/21 18:55, Richard Biener wrote: > > > On Thu, 21 Oct 2021, Xionghu Luo wrote: > > > > > >> > > >> > > >> On 2021/10/15 13:51, Xionghu Luo via Gcc-patches wrote: > > >>> > > >>> > > >>> On 2021/9/23 20:17, Richard Biener wrote: >

Re: [PATCH] Fix loop split incorrect count and probability

2021-10-26 Thread Jan Hubicka via Gcc-patches
> > > That said, likely the profile update cannot be done uniformly > for all blocks of a loop? For the loop: for (i = 0; i < n; i = inc (i)) { if (ga) ga = do_something (); } to: for (i = 0; i < x; i = inc (i)) { if (true) ga = do_something (); if (!ga

Re: [PATCH] Fix loop split incorrect count and probability

2021-10-26 Thread Xionghu Luo via Gcc-patches
On 2021/10/26 21:05, Jan Hubicka wrote: >>> > >> That said, likely the profile update cannot be done uniformly >> for all blocks of a loop? > > For the loop: > > for (i = 0; i < n; i = inc (i)) > { > if (ga) > ga = do_something (); > } > > to: > > for (i = 0; i < x; i =